#583 closed defect (fixed)
Morph atoms don't move if alt locs are present
| Reported by: | Tom Goddard | Owned by: | Tom Goddard |
|---|---|---|---|
| Priority: | major | Milestone: | |
| Component: | Structure Comparison | Version: | |
| Keywords: | Cc: | pett@… | |
| Blocked By: | Blocking: | ||
| Notify when closed: | Platform: | all | |
| Project: | ChimeraX |
Change History (5)
comment:1 by , 9 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
follow-up: 2 comment:2 by , 9 years ago
dealtloc is a pretty cryptic name. Maybe it could be changed to the more self-explanatory delete_altlocs?
follow-up: 3 comment:3 by , 9 years ago
I thought about it for awhile before calling it "dealtloc". To me, delete_altlocs sounds too much like the atoms with altlocs are being deleted entirely. It's a rarely used function anyway so the name probably doesn't have to be perfect. Sent from my iPad
follow-up: 4 comment:4 by , 9 years ago
I think the interpretation of delete_altlocs as deleting alternative locations and not the atom itself is what the name suggests. It makes no sense to selectively delete atoms that have altlocs, so I can’t imagine anyone trying to use it to do that. And the name is much clearer than dealtloc (which I at first parsed as “deal” or “dealt” rather than “de-". But it is of course your call.
Note:
See TracTickets
for help on using tickets.
Fixed; implemented a 'dealtloc' structure method that morph calls after copying the starting structure