Opened 9 years ago

Closed 9 years ago

#382 closed defect (fixed)

cannot use "format" keyword with "save"

Reported by: Elaine Meng Owned by: Tom Goddard
Priority: critical Milestone:
Component: Input/Output Version:
Keywords: Cc:
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

Using UCSF ChimeraX version: 0.1 (2016-07-22)

command:
save #3 ~/Desktop/test4 format mrc

gives:
Traceback (most recent call last):
File "/Users/meng/Desktop/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/chimerax/cmd_line/gui.py", line 168, in execute
cmd.run(cmd_text)
File "/Users/meng/Desktop/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/chimerax/core/commands/cli.py", line 2194, in run
results.append(ci.function(session, kw_args))
File "/Users/meng/Desktop/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/chimerax/core/commands/save.py", line 57, in save
fmt = format_from_short_name(format, save=True, open=False)
NameError: name 'format_from_short_name' is not defined

Some other problems that may be related:
(1) "usage save map" gives format list that includes image and session formats
(2) command: save ~/Desktop/junk format tiff
gives:
Expected a keyword

Change History (2)

comment:1 by Elaine Meng, 9 years ago

It would be great if suffix ".tiff" were accepted in addition to ".tif"

Another possibly related problem is that in the File... Save dialog, changing from Session to Image File gives traceback ending in:

ImportError: cannot import name 'image_formats'

comment:2 by Tom Goddard, 9 years ago

Resolution: fixed
Status: newclosed

Fixed save command format option.
Fixed "usage map save" so it lists only map formats.
Made save command recognize ".tiff" and ".jpeg" file suffixes.

Made "save ~/Desktop/junk format tiff" work. Problem was that ~/Desktop/junk was interpreted as an atom spec instead of a path! Best idea I had for fixing this is to make models argument come after path argument.
Made models argument an optional argument after required path argument. Formerly models was the first argument but was optional.

Note: See TracTickets for help on using tickets.