Opened 9 years ago

Closed 9 years ago

#360 closed defect (fixed)

cartoon tether with atomspec gives error

Reported by: Elaine Meng Owned by: Conrad Huang
Priority: major Milestone:
Component: Depiction Version:
Keywords: Cc:
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

I can use "cartoon tether" without error if I don't specify any atoms or models, but with an atomspec it gives a traceback. For example,
cartoon tether shape cylinder
...is fine, but
cartoon tether #2 shape cylinder
...gives the error below. Happens with all tether options, not just shape.

Actually it is fine with me if these tether settings are global rather than per-model, but the current command usage information suggests they are per-model.

Traceback (most recent call last):
File "/Users/meng/Desktop/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/chimerax/cmd_line/gui.py", line 167, in execute
cmd.run(cmd_text)
File "/Users/meng/Desktop/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/chimerax/core/commands/cli.py", line 2194, in run
results.append(ci.function(session, kw_args))
File "/Users/meng/Desktop/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/chimerax/exp_cmd/cartoon.py", line 127, in cartoon_tether
structures.ribbon_tether_shapes = ts
AttributeError: 'list' object has no attribute 'ribbon_tether_shapes'

Change History (1)

comment:1 by Conrad Huang, 9 years ago

Resolution: fixed
Status: newclosed

Fixed in 47505c4/chimerax. The command parsing code was returning a list of AtomicStructure instances instead of a single AtomicStructures instance.

Since AtomicStructures instances are iterable just like lists, there should be no other impact from this change. But you never know...

Note: See TracTickets for help on using tickets.