Opened 10 years ago

Closed 9 years ago

#239 closed defect (fixed)

File... Save GUI save image adds ".cxs" before image suffix

Reported by: Elaine Meng Owned by: greg
Priority: major Milestone:
Component: Input/Output Version:
Keywords: Cc: Conrad Huang, pett, Tom Goddard
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

If I choose menu: File... Save, then "Image File" with format:PNG, and enter a filename without suffix, what I get is filename.cxs.png.

Two secondary/related issues:

(1) saving session via this GUI is reported in the Log, but not saving an image. Should be consistent and report both.

(2) saving session without specifying suffix gives .cxs (not gzipped). That is fine with me, but then the command "save session" should also give a not-gzipped result. Or, both should gzip. Definitely confusing if they are different. Consistency is the hobgoblin of my little mind.

Change History (5)

comment:1 by Elaine Meng, 10 years ago

Actually, it is dependent on what you just did previously with that GUI. If you saved a session before saving the image, you get the extra suffix. If you saved an image before saving the session, you could get something like filename.png.cxs.

comment:2 by Elaine Meng, 9 years ago

Testing suggests the problem with multiple file suffixes is fixed, as well as the related issue #2. However, #1 still stands.

comment:3 by Greg Couch, 9 years ago

I can't reproduce this on Windows. Can you double check that it's still a bug with today's daily build? There's a chance that the fix for #474 also fixed this bug.

comment:4 by pett, 9 years ago

As Elaine said, that part of the bug is fixed. The part that isn't is:

(1) saving session via this GUI is reported in the Log, but not saving an image. Should be consistent and report both.

comment:5 by Greg Couch, 9 years ago

Resolution: fixed
Status: newclosed

Must be dyslexic. Added logging the filename when saving an image via the dialog. The code should probably be rewritten to use the save command like the saving a session from the dialog does, and the logging should be part of the save command.

Note: See TracTickets for help on using tickets.