Rainbow command: Missing required "objects" positional argument

[Tom Goddard]

When the rainbow command is issued with no arguments it gives the error

Missing required "objects" positional argument

The rainbow command has a required objects arguments, registered with type

Or(ObjectsArg, EmptyArg)

and should permit no argument to be specified.

Another oddity of this error is that the log shows the error message and but does not show the "rainbow" command was typed.

[Greg Couch]

This one is difficult, since there is no text after the command name, the argument type annotation is never checked.

[goddard@…]

I wonder if there is some change to our command registration API could help.  Specifically I think having “required” options that aren’t actually required is confusing and is going to confuse any outside developers.

signature.asc​

[goddard@…]

Added by email2trac

[Greg Couch]

Fixed by continuing to parse required positional arguments with an empty string. Had to change atomspec parsing to given AnnotationError instead of an AssertionError when given an empty string.