Opened 7 years ago
Closed 6 years ago
#1175 closed enhancement (fixed)
Add define and undefine CModule/CLibrary entries
| Reported by: | Tristan Croll | Owned by: | Conrad Huang |
|---|---|---|---|
| Priority: | major | Milestone: | |
| Component: | Tool Shed | Version: | |
| Keywords: | Cc: | Eric Pettersen, Greg Couch, Tom Goddard | |
| Blocked By: | Blocking: | ||
| Notify when closed: | Platform: | all | |
| Project: | ChimeraX |
Description
ISOLDE is getting rather large now, and the C++ portion is divided into five different compiled libraries (and counting). In order to link them to each other (and, ultimately, to let other packages use ISOLDE's C++ API) they're all going to need their own import/export macros - which in turn means I need to pass library-specific macro definitions in.
Accordingly, I've made some edits to bundle_builder.py to allow two new elements in <CModule> and <CLibrary> entries in bundle_info.xml:
<CLibrary name="foo"> <Define>BAR1</Define> <Define>BAR2=1</Define> <Undefine>FOOBAR</Undefine> <SourceFile>src/foo.cpp</SourceFile> </CLibrary>
Also addressed a handful of bugs described in #1147 and #1172, and set the CLibrary compilation to verbose so the compiler commands are echoed to the shell.
Attachments (2)
Change History (5)
by , 7 years ago
| Attachment: | bundle_builder.py added |
|---|
comment:1 by , 7 years ago
follow-up: 1 comment:2 by , 7 years ago
Another addition to the wish-list: a <CompileArgument> field (mainly so I can add -fvisibility=hidden to work nicely with ..._IMEX macros).
comment:3 by , 6 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Added Tristan's patch in 0d03fc7.
bundle_builder-1.py