Opened 8 years ago
Closed 8 years ago
#915 closed defect (fixed)
"rename" error changing model number in some cases
| Reported by: | Elaine Meng | Owned by: | Eric Pettersen |
|---|---|---|---|
| Priority: | minor | Milestone: | |
| Component: | General Controls | Version: | |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Notify when closed: | Platform: | all | |
| Project: | ChimeraX |
Description
Reclassify as desired.
If I have two models open, #1 and #2, entering this command works fine
... result is #2 and #2.1 as you told me was the intended behavior, but the Log strips the second "#" even though the Command History shows it. However, if I instead use command
... there is an error and the model number isn't changed (Log has the second "#" stripped again, but that seems orthogonal to the error... or was I not supposed to include it in the command??)
Log shows:
rename #2 id 1
Error processing trigger "frame drawn"
Traceback (most recent call last):
File "/Users/chimera/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chimerax/core/triggerset.py", line 126, in invoke
return self._func(self._name, data)
File "/Users/chimera/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chimerax/model_panel/tool.py", line 155, in _fill_tree
item.setText(self.ID_COLUMN, model_id_string)
AttributeError: 'NoneType' object has no attribute 'setText'
Change History (2)
comment:1 by , 8 years ago
| Component: | Logging → General Controls |
|---|---|
| Owner: | changed from to |
comment:2 by , 8 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Fixed. Needed to always rebuild model panel if model IDs change, and get the ID-change trigger to fire when models reparented.
There are two bugs here. The first is the logged command drops the "#" character. Greg issue, but easy to fix so I fixed it. Second bug is in Model Panel. Reassigning to Eric to handle that.