Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#909 closed defect (fixed)

Closing a labeled pseudobond model causes an error

Reported by: meng@… Owned by: Tom Goddard
Priority: blocker Milestone: 0.5
Component: Graphics Version:
Keywords: Cc: Eric Pettersen
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

open 1zik 1gcn
hb #1 restrict #2 show t rev t
label color yellow
move y -10 mod #2
~hb

results in:

Error processing trigger "graphics update"
Traceback (most recent call last):
File "/Users/pett/src/chimerax/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chimerax/core/triggerset.py", line 126, in invoke
return self._func(self._name, data)
File "/Users/pett/src/chimerax/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chimerax/label/label3d.py", line 333, in _update_graphics_if_needed
self.delete_labels(delo)
File "/Users/pett/src/chimerax/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chimerax/label/label3d.py", line 290, in delete_labels
self.session.models.close([self])
File "/Users/pett/src/chimerax/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chimerax/core/models.py", line 419, in close
self.remove(models)
File "/Users/pett/src/chimerax/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chimerax/core/models.py", line 397, in remove
mlist.sort(key=lambda m: len(m.id), reverse=True)
File "/Users/pett/src/chimerax/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chimerax/core/models.py", line 397, in <lambda>
mlist.sort(key=lambda m: len(m.id), reverse=True)
TypeError: object of type 'NoneType' has no len()

Change History (3)

comment:1 by Eric Pettersen, 8 years ago

Not 100% sure who's responsible for closing/deleting the label model if the pseudobond group is removed/closed.

comment:2 by Tom Goddard, 8 years ago

Resolution: fixed
Status: assignedclosed

Fixed.

The ~hbond command deleted the pseudobond group showing the distances. The labels were a child of the pseudobond group and should have been deleted too, but a bug in the model close code caused child models not to be deleted (although they were removed from the open model list). The undead label model then gives an error.

comment:3 by Eric Pettersen, 8 years ago

Milestone: Beta Release0.5

Milestone renamed

Note: See TracTickets for help on using tickets.