Opened 3 years ago

Closed 3 years ago

#7518 closed defect (fixed)

Modeller web service errors not reported

Reported by: wgrubbe@… Owned by: Zach Pearson
Priority: high Milestone: 1.5
Component: Web Services Version:
Keywords: Cc: pett
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

Modeling a loop where the loop residues aren't provided fails but doesn't report the error back to the user

Change History (4)

comment:1 by pett, 3 years ago

Cc: pett added; Zach Pearson removed
Milestone: → 1.5
Owner: changed from pett to Zach Pearson

comment:2 by Zach Pearson, 3 years ago

OK, found the bug. In core.Task, we call on_finish only if the job exited_normally, but we ALREADY expect the module to handle errors in on_finish, so we need to run it regardless of what happens.

I'm not closing this ticket quite yet because I need to ensure that on_finish is actually sane, but I just wanted to report that I found where the error was.

comment:4 by Zach Pearson, 3 years ago

Resolution: → fixed
Status: assigned → closed
Note: See TracTickets for help on using tickets.