Opened 3 years ago

Closed 3 years ago

#7431 closed defect (fixed)

"close session" does not reset volume model color rotation

Reported by: Elaine Meng Owned by: Tom Goddard
Priority: moderate Milestone:
Component: Volume Data Version:
Keywords: Cc:
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

If I open a map, then use "close session", then reopen the map, it is now in the second volume color, yellowish instead of gray.

Change History (5)

comment:1 by Tom Goddard, 3 years ago

Resolution: fixed
Status: assignedclosed

Fixed.

I made it reset the volume colors whenever you open a volume and no other volumes are open. The code was trying to do this before but it reset the colors when opening a volume and no other models were opened. So if you opened a volume, then "close session", then open another volume it was reseting the colors. But if you open a volume, "close session", then open a PDB, then open a volume, the colors were not getting reset. Now whenever you have no volumes open the colors are reset when the next volume is opened.

comment:2 by Elaine Meng, 3 years ago

Hmmm, now it does work for original test case: open map, close session, reopen map. However, if I understand your comment above, the following should reset the coloring but it does not:

open 2gbp
molmap protein 5
close session
open 2gbp
molmap protein 5

(or a different molmap command... either way keeps going to the next color)

comment:3 by Elaine Meng, 3 years ago

Resolution: fixed
Status: closedreopened

Also the following does not reset volume coloring, so I'm pretty sure this is not fixed:

open atomic structure, open map, close session
open atomic structure, open map
... map has different color than the first time ... can keep cycling, is new map color each time

tested in ChimeraX 1.5.dev202208130111 (2022-08-13)

comment:4 by Tom Goddard, 3 years ago

Forgot to commit the fix to the git repository. Committed now and will be in tonight's ChimeraX builds.

comment:5 by Tom Goddard, 3 years ago

Resolution: fixed
Status: reopenedclosed
Note: See TracTickets for help on using tickets.