Opened 3 years ago

Closed 3 years ago

#7430 closed defect (fixed)

why does this script show DICOM as surface style?

Reported by: Elaine Meng Owned by: Tom Goddard
Priority: moderate Milestone:
Component: Volume Data Version:
Keywords: Cc:
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

In older versions of ChimeraX (e.g. 0.9) this short script given in-line below shows the lung slab just in the image style, but in newer versions (tried 1.3, 1.4, 1.5 daily build) it also shows the bones as isosurfaces, which I did not expect. Images leftlungnew.png leftlungold.png attached.

Data is /wynton/group/ferrin/usr.local/projects/chimerax/www/data/dicom/4-24533.zip

# same RIDER chest CT used in DICOM-VR tutorial, healthy left lung
#
open 4-24533 format dicom
windowsize 360 720
camera ortho
volume #1.1.1.1 region 267,266,24,496,325,228
volume appearance "Airways II"
turn x 90; turn z 180

Attachments (3)

leftlungnew.png (225.4 KB ) - added by Elaine Meng 3 years ago.
leftlungold.png (180.7 KB ) - added by Elaine Meng 3 years ago.
leftlung.cxc (226 bytes ) - added by Elaine Meng 3 years ago.

Download all attachments as: .zip

Change History (9)

by Elaine Meng, 3 years ago

Attachment: leftlungnew.png added

by Elaine Meng, 3 years ago

Attachment: leftlungold.png added

comment:1 by Tom Goddard, 3 years ago

Just opening the dicom data (the first command) causes both a surface and image style rendering to be shown for a single plane. That should not show the surface.

comment:2 by Tom Goddard, 3 years ago

Mysteriously the script with only the open command makes the surface, but just typing the command or using menu File / Open DICOM Folder... does not create the surface!

comment:3 by Tom Goddard, 3 years ago

Two years ago, on April 7, 2020, I made a change so that in scripts if a volume change is made the surface is recomputed immediately so that subsequent commands working on volumes will use the correct surface.

https://github.com/RBVI/ChimeraX/commit/a16eecb70509777237e67d297d86193f2f1cc584

Unfortunately this is somehow causing dicom data to show a surface instead of just image rendering. The problem is not specific to DICOM data. If a tomogram that initially shows a single plane is opened in a script it also shows both surface and image styles.

comment:4 by Tom Goddard, 3 years ago

Resolution: fixed
Status: assignedclosed

Fixed.

The code that made volumes update surfaces immediately in scripts was creating a surface when the volume was opened even before the initial style was set to image. Made it not update surfaces in scripts until after the initial volume style has been set during opening.

comment:5 by Elaine Meng, 3 years ago

Resolution: fixed
Status: closedreopened

This is not fixed... tested in UCSF ChimeraX version: 1.5.dev202208130111 (2022-08-13)

Script leftlung.cxc attached in case it makes testing easier.

by Elaine Meng, 3 years ago

Attachment: leftlung.cxc added

comment:6 by Tom Goddard, 3 years ago

Resolution: fixed
Status: reopenedclosed

Forgot to commit the fix to the git code repository. I guess I was in a rush the day before vacation. Committed now and will be in tonight's ChimeraX builds.

Note: See TracTickets for help on using tickets.