Opened 3 years ago

Closed 3 years ago

Last modified 10 months ago

#6788 closed enhancement (fixed)

Remove Windows crash reporting in ChimeraX 1.4

Reported by: Tom Goddard Owned by: Tom Goddard
Priority: moderate Milestone: 1.4
Component: Platform Version:
Keywords: Cc: pett
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description (last modified by pett)

We have not found Windows crash reports useful enough to justify the time spent triaging the many reports. So Eric and I believe we should not offer users crash report panel on Windows.

We are leaving this in until a week before release to see if Python 3.9.11 has really fixed the Open dialog crashes.

In the long term we may reenable Windows crash reporting but put filtering into our server CGI script that receives the reports to filter out ones (based on pattern matching) that are not worth creating bug reports for. That filtering is the subject of ticket #6654.

Change History (4)

comment:1 by Tom Goddard, 3 years ago

Milestone: 1.4

comment:2 by Tom Goddard, 3 years ago

Resolution: fixed
Status: assignedclosed

Done.

Disabled crash reporting on Windows in ChimeraX 1.4 and develop branches. It no longer activates Python faulthandler and does not record the log to a file so crashes will not be detected the next time ChimeraX starts after a crash.

comment:3 by Tom Goddard, 3 years ago

In testing this change I tried segfaulting ChimeraX using ctypes. I was slightly horrified to find it did not crash, and instead gave an OSError access violation and no Report a Bug button. So it appears that segfaults in ctypes calls made by ChimeraX probably never got reported. When I tested by segfaulting (dereference null pointer) in the map contour.cpp code which is called as a hand wrapped Python module it does exit and faulthandler gives a correct traceback. These findings are detailed in ticket #6939.

comment:4 by pett, 10 months ago

Description: modified (diff)

The faulthandler output seems better now, so re-enabling it in the daily build.

Note: See TracTickets for help on using tickets.