![[ChimeraX Issue Tracking System]](/trac/ChimeraX/chrome/site/ChimeraX-icon.svg){kind=icon}
Opened 4 years ago
Closed 4 years ago
#6297 closed enhancement (fixed)
Graphics is computing mesh edges for surface twice
| Reported by: | Tom Goddard | Owned by: | Tom Goddard |
|---|---|---|---|
| Priority: | moderate | Milestone: | |
| Component: | Graphics | Version: | |
| Keywords: | Cc: | Tristan Croll | |
| Blocked By: | Blocking: | ||
| Notify when closed: | Platform: | all | |
| Project: | ChimeraX |
Description
The graphics code computes the mesh edges for a triangulated surface twice when displaying mesh style. That mesh edge calculation is very slow as noted in ticket #6279, three times slower than computing the volume contour surface which is then shown as mesh. The extra edge calculation is for the selection highlight but occurs even if there is no selection.
Would be good to optimize this so only one calculation of mesh edges is done, since it slows down ISOLDE considerably updating x-ray maps for new phases several times per second as described in #5964.
Note:
See TracTickets
for help on using tickets.
Fixed.
I made the selection highlight reuse the mesh edges from the non-highlighted surface when the surface is not selected or fully selected. If it is partially selected (no tools do this for volume surfaces that I know of) then the calculation would be done twice.