Opened 4 years ago

Closed 4 years ago

#5326 closed defect (fixed)

Blastprotein: Some NR results don't have all the columns

Reported by: Zach Pearson Owned by: Zach Pearson
Priority: major Milestone: 1.3
Component: Sequence Version:
Keywords: Cc: Elaine Meng
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

Spinoff of #5228

Change History (4)

comment:1 by pett, 4 years ago

Component: Unassigned → Sequence

comment:2 by Zach Pearson, 4 years ago

Cc: Elaine Meng added

comment:3 by Zach Pearson, 4 years ago

This one was obscure.

In the original BLAST parsing code, we simultaneously added all the hits to a list and a dictionary. The dictionary was then passed to a function called add_info that was responsible for adding info from RCSB's GraphQL API to the hits.

Q: If the object in the list and the object in the dict are the same, and the object is mutable, any changes made by mutating the object through the dict should show up when we try to access the object through the list, right?
A: Sometimes!

I don't know why exactly this would usually work except for 1hag, but generating the list of hits dynamically with list(match_chains.values()) + list(sequence_only_hits.values()) got the results to display correctly with all the columns.

comment:4 by Zach Pearson, 4 years ago

Resolution: → fixed
Status: assigned → closed

Should be fixed by ​this commit.

Note: See TracTickets for help on using tickets.