Opened 9 years ago
Closed 9 years ago
#455 closed defect (fixed)
Capitalization of multi-character chain ids in atom specs
| Reported by: | Owned by: | Greg Couch | |
|---|---|---|---|
| Priority: | major | Milestone: | |
| Component: | Command Line | Version: | |
| Keywords: | Cc: | pett@…, gregc@… | |
| Blocked By: | Blocking: | ||
| Notify when closed: | Platform: | all | |
| Project: | ChimeraX |
Description
Begin forwarded message:
From: Tristan Croll
Subject: Bug: chain selection not case sensitive
Date: October 22, 2016 at 7:26:46 AM PDT
To: Tom Goddard
Hi Tom,
Just noticed that if I load a large structure with two-character mixed-case chain names (4v8r) and type:
select /Aa
in the command line, ChimeraX selects both chains Aa and AA (likewise if I use select /AA).
Cheers,
Tristan
Change History (7)
comment:1 by , 9 years ago
| Cc: | added |
|---|
comment:2 by , 9 years ago
| Cc: | added |
|---|
comment:3 by , 9 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:4 by , 9 years ago
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Added code to mmCIF reader to set the lower_case_chains flag if need be.
comment:5 by , 9 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
comment:6 by , 9 years ago
lower_case_chains is not extruded to python layer yet, so it isn't checked.
comment:7 by , 9 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Changed mmCIF reader to examine all letters in chain id for lowercase letters.
exposed lower_case_chains attribute to Python layer.
use lower_case_chains attribute in atom spec code to decide whether to use case insensitive test or not.
There is a boolean attribute of Structure (lower_case_chains) that has to be set by the input readers if there are chain IDs with lower-case characters in them. Currently it is only set by the PDB reader. This means it needs to be set by the mmCIF reader, made visible to the Python layer, and used by the atom-spec parser/evaluator.
--Eric