Opened 5 years ago

Last modified 5 years ago

#4508 assigned enhancement

Adjust color brightness/contrast

Reported by: Tristan Croll Owned by: Tom Goddard
Priority: normal Milestone:
Component: Depiction Version:
Keywords: Cc: Greg Couch, Elaine Meng, pett
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

The following bug report has been submitted:
Platform:        Linux-3.10.0-1127.19.1.el7.x86_64-x86_64-with-centos-7.8.2003-Core
ChimeraX Version: 1.1 (2020-09-09 22:22:27 UTC)
Description
Minor suggestion... Composing some complex scenes for publication, and found myself wishing there were brightness (push selected colors towards white/black) and contrast (push selected colors towards/away from grey) adjustment silders. 

OpenGL version: 3.3.0 NVIDIA 455.32.00
OpenGL renderer: TITAN Xp/PCIe/SSE2
OpenGL vendor: NVIDIA Corporation
Manufacturer: Dell Inc.
Model: Precision T5600
OS: CentOS Linux 7 Core
Architecture: 64bit ELF
CPU: 32 Intel(R) Xeon(R) CPU E5-2687W 0 @ 3.10GHz
Cache Size: 20480 KB
Memory:
	              total        used        free      shared  buff/cache   available
	Mem:            62G        9.9G         37G        182M         15G         52G
	Swap:          4.9G          0B        4.9G

Graphics:
	03:00.0 VGA compatible controller [0300]: NVIDIA Corporation GP102 [TITAN Xp] [10de:1b02] (rev a1)	
	Subsystem: NVIDIA Corporation Device [10de:11df]	
	Kernel driver in use: nvidia
PyQt version: 5.12.3
Compiled Qt version: 5.12.4
Runtime Qt version: 5.12.9
Installed Packages:
    alabaster: 0.7.12
    appdirs: 1.4.4
    Babel: 2.8.0
    backcall: 0.2.0
    blockdiag: 2.0.1
    certifi: 2020.6.20
    chardet: 3.0.4
    ChimeraX-AddH: 2.1.3
    ChimeraX-AlignmentAlgorithms: 2.0
    ChimeraX-AlignmentHdrs: 3.2
    ChimeraX-AlignmentMatrices: 2.0
    ChimeraX-Alignments: 2.1
    ChimeraX-Arrays: 1.0
    ChimeraX-Async: 0.1
    ChimeraX-Atomic: 1.6.1
    ChimeraX-AtomSearch: 2.0
    ChimeraX-AxesPlanes: 2.0
    ChimeraX-BasicActions: 1.1
    ChimeraX-BILD: 1.0
    ChimeraX-BlastProtein: 1.0.1
    ChimeraX-BondRot: 2.0
    ChimeraX-BugReporter: 1.0
    ChimeraX-BuildStructure: 2.0
    ChimeraX-Bumps: 1.0
    ChimeraX-BundleBuilder: 1.0
    ChimeraX-ButtonPanel: 1.0
    ChimeraX-CageBuilder: 1.0
    ChimeraX-CellPack: 1.0
    ChimeraX-Centroids: 1.1
    ChimeraX-ChemGroup: 2.0
    ChimeraX-Clashes: 2.0
    ChimeraX-Clipper: 0.15.0
    ChimeraX-ColorActions: 1.0
    ChimeraX-ColorGlobe: 1.0
    ChimeraX-CommandLine: 1.1.3
    ChimeraX-ConnectStructure: 2.0
    ChimeraX-Contacts: 1.0
    ChimeraX-Core: 1.1
    ChimeraX-CoreFormats: 1.0
    ChimeraX-coulombic: 1.0.1
    ChimeraX-Crosslinks: 1.0
    ChimeraX-Crystal: 1.0
    ChimeraX-DataFormats: 1.0
    ChimeraX-Dicom: 1.0
    ChimeraX-DistMonitor: 1.1
    ChimeraX-DistUI: 1.0
    ChimeraX-Dssp: 2.0
    ChimeraX-EMDB-SFF: 1.0
    ChimeraX-ExperimentalCommands: 1.0
    ChimeraX-FileHistory: 1.0
    ChimeraX-FunctionKey: 1.0
    ChimeraX-Geometry: 1.1
    ChimeraX-gltf: 1.0
    ChimeraX-Graphics: 1.0
    ChimeraX-Hbonds: 2.0
    ChimeraX-Help: 1.0
    ChimeraX-HKCage: 1.3
    ChimeraX-IHM: 1.0
    ChimeraX-ImageFormats: 1.0
    ChimeraX-IMOD: 1.0
    ChimeraX-IO: 1.0
    ChimeraX-ISOLDE: 1.1.0
    ChimeraX-Label: 1.0
    ChimeraX-LinuxSupport: 1.0
    ChimeraX-ListInfo: 1.0
    ChimeraX-Log: 1.1.1
    ChimeraX-LookingGlass: 1.1
    ChimeraX-Map: 1.0.1
    ChimeraX-MapData: 2.0
    ChimeraX-MapEraser: 1.0
    ChimeraX-MapFilter: 2.0
    ChimeraX-MapFit: 2.0
    ChimeraX-MapSeries: 2.0
    ChimeraX-Markers: 1.0
    ChimeraX-Mask: 1.0
    ChimeraX-MatchMaker: 1.1
    ChimeraX-MDcrds: 2.0
    ChimeraX-MedicalToolbar: 1.0.1
    ChimeraX-Meeting: 1.0
    ChimeraX-MLP: 1.0
    ChimeraX-mmCIF: 2.2
    ChimeraX-MMTF: 2.0
    ChimeraX-Modeller: 1.0
    ChimeraX-ModelPanel: 1.0
    ChimeraX-ModelSeries: 1.0
    ChimeraX-Mol2: 2.0
    ChimeraX-Morph: 1.0
    ChimeraX-MouseModes: 1.0
    ChimeraX-Movie: 1.0
    ChimeraX-Neuron: 1.0
    ChimeraX-Nucleotides: 2.0
    ChimeraX-OpenCommand: 1.2.1
    ChimeraX-PDB: 2.1
    ChimeraX-PDBBio: 1.0
    ChimeraX-Phenix: 0.1
    ChimeraX-PickBlobs: 1.0
    ChimeraX-Positions: 1.0
    ChimeraX-PresetMgr: 1.0
    ChimeraX-PubChem: 2.0
    ChimeraX-Read-Pbonds: 1.0
    ChimeraX-Registration: 1.1
    ChimeraX-RemoteControl: 1.0
    ChimeraX-ResidueFit: 1.0
    ChimeraX-RestServer: 1.0
    ChimeraX-RNALayout: 1.0
    ChimeraX-RotamerLibMgr: 2.0
    ChimeraX-RotamerLibsDunbrack: 2.0
    ChimeraX-RotamerLibsDynameomics: 2.0
    ChimeraX-RotamerLibsRichardson: 2.0
    ChimeraX-SaveCommand: 1.2
    ChimeraX-SchemeMgr: 1.0
    ChimeraX-SDF: 2.0
    ChimeraX-Segger: 1.0
    ChimeraX-Segment: 1.0
    ChimeraX-SeqView: 2.2
    ChimeraX-Shape: 1.0.1
    ChimeraX-Shell: 1.0
    ChimeraX-Shortcuts: 1.0
    ChimeraX-ShowAttr: 1.0
    ChimeraX-ShowSequences: 1.0
    ChimeraX-SideView: 1.0
    ChimeraX-Smiles: 2.0
    ChimeraX-SmoothLines: 1.0
    ChimeraX-SpaceNavigator: 1.0
    ChimeraX-StdCommands: 1.0.4
    ChimeraX-STL: 1.0
    ChimeraX-Storm: 1.0
    ChimeraX-Struts: 1.0
    ChimeraX-Surface: 1.0
    ChimeraX-SwapAA: 2.0
    ChimeraX-SwapRes: 2.0
    ChimeraX-TapeMeasure: 1.0
    ChimeraX-Test: 1.0
    ChimeraX-Toolbar: 1.0
    ChimeraX-ToolshedUtils: 1.0
    ChimeraX-Tug: 1.0
    ChimeraX-UI: 1.2.3
    ChimeraX-uniprot: 2.0
    ChimeraX-ViewDockX: 1.0
    ChimeraX-Vive: 1.1
    ChimeraX-VolumeMenu: 1.0
    ChimeraX-VTK: 1.0
    ChimeraX-WavefrontOBJ: 1.0
    ChimeraX-WebCam: 1.0
    ChimeraX-WebServices: 1.0
    ChimeraX-Zone: 1.0
    colorama: 0.4.3
    comtypes: 1.1.7
    cxservices: 1.0
    cycler: 0.10.0
    Cython: 0.29.20
    decorator: 4.4.2
    distlib: 0.3.1
    distro: 1.5.0
    docutils: 0.16
    filelock: 3.0.12
    funcparserlib: 0.3.6
    grako: 3.16.5
    graphviz: 0.14.1
    h5py: 2.10.0
    html2text: 2020.1.16
    idna: 2.10
    ihm: 0.16
    imagecodecs: 2020.5.30
    imagecodecs-lite: 2020.1.31
    imagesize: 1.2.0
    ipykernel: 5.3.0
    ipython: 7.15.0
    ipython-genutils: 0.2.0
    jedi: 0.17.2
    Jinja2: 2.11.2
    jupyter-client: 6.1.3
    jupyter-core: 4.6.3
    kiwisolver: 1.2.0
    line-profiler: 2.1.2
    lxml: 4.5.1
    MarkupSafe: 1.1.1
    matplotlib: 3.2.1
    msgpack: 1.0.0
    netifaces: 0.10.9
    networkx: 2.4
    numexpr: 2.7.1
    numpy: 1.18.5
    numpydoc: 1.0.0
    objgraph: 3.4.1
    openvr: 1.12.501
    packaging: 20.4
    ParmEd: 3.2.0
    parso: 0.7.1
    pexpect: 4.8.0
    pickleshare: 0.7.5
    Pillow: 7.1.2
    pip: 20.2.2
    pkginfo: 1.5.0.1
    prompt-toolkit: 3.0.7
    psutil: 5.7.0
    ptyprocess: 0.6.0
    pycollada: 0.7.1
    pydicom: 2.0.0
    Pygments: 2.6.1
    PyOpenGL: 3.1.5
    PyOpenGL-accelerate: 3.1.5
    pyparsing: 2.4.7
    PyQt5-commercial: 5.12.3
    PyQt5-sip: 4.19.19
    PyQtWebEngine-commercial: 5.12.1
    python-dateutil: 2.8.1
    pytz: 2020.1
    pyzmq: 19.0.2
    qtconsole: 4.7.4
    QtPy: 1.9.0
    RandomWords: 0.3.0
    requests: 2.24.0
    scipy: 1.4.1
    Send2Trash: 1.5.0
    SEQCROW: 0.24.3
    setuptools: 49.4.0
    sfftk-rw: 0.6.6.dev0
    six: 1.15.0
    snowballstemmer: 2.0.0
    sortedcontainers: 2.2.2
    Sphinx: 3.1.1
    sphinxcontrib-applehelp: 1.0.2
    sphinxcontrib-blockdiag: 2.0.0
    sphinxcontrib-devhelp: 1.0.2
    sphinxcontrib-htmlhelp: 1.0.3
    sphinxcontrib-jsmath: 1.0.1
    sphinxcontrib-qthelp: 1.0.3
    sphinxcontrib-serializinghtml: 1.1.4
    suds-jurko: 0.6
    tables: 3.6.1
    tifffile: 2020.6.3
    tinyarray: 1.2.2
    tornado: 6.0.4
    traitlets: 5.0.4
    urllib3: 1.25.10
    versioneer: 0.18
    wcwidth: 0.2.5
    webcolors: 1.11.1
    wheel: 0.34.2

Change History (9)

in reply to:  1 ; comment:1 by Tristan Croll, 5 years ago

... I guess that would be saturation, rather than contrast.
________________________________
From: ChimeraX <ChimeraX-bugs-admin@cgl.ucsf.edu>
Sent: 14 April 2021 20:10
To: Tristan Croll <tic20@cam.ac.uk>
Subject: [ChimeraX] #4508: ChimeraX bug report submission

#4508: ChimeraX bug report submission
---------------------------+-----------------------------
 Reporter:  Tristan Croll  |                Type:  defect
   Status:  new            |            Priority:  normal
Component:  Unassigned     |          Blocked By:
 Blocking:                 |  Notify when closed:
---------------------------+-----------------------------
 {{{
 The following bug report has been submitted:
 Platform:        Linux-3.10.0-1127.19.1.el7.x86_64-x86_64-with-
 centos-7.8.2003-Core
 ChimeraX Version: 1.1 (2020-09-09 22:22:27 UTC)
 Description
 Minor suggestion... Composing some complex scenes for publication, and
 found myself wishing there were brightness (push selected colors towards
 white/black) and contrast (push selected colors towards/away from grey)
 adjustment silders.

 OpenGL version: 3.3.0 NVIDIA 455.32.00
 OpenGL renderer: TITAN Xp/PCIe/SSE2
 OpenGL vendor: NVIDIA Corporation
 Manufacturer: Dell Inc.
 Model: Precision T5600
 OS: CentOS Linux 7 Core
 Architecture: 64bit ELF
 CPU: 32 Intel(R) Xeon(R) CPU E5-2687W 0 @ 3.10GHz
 Cache Size: 20480 KB
 Memory:
                       total        used        free      shared
 buff/cache   available
         Mem:            62G        9.9G         37G        182M
 15G         52G
         Swap:          4.9G          0B        4.9G

 Graphics:
         03:00.0 VGA compatible controller [0300]: NVIDIA Corporation GP102
 [TITAN Xp] [10de:1b02] (rev a1)
         Subsystem: NVIDIA Corporation Device [10de:11df]
         Kernel driver in use: nvidia
 PyQt version: 5.12.3
 Compiled Qt version: 5.12.4
 Runtime Qt version: 5.12.9
 Installed Packages:
     alabaster: 0.7.12
     appdirs: 1.4.4
     Babel: 2.8.0
     backcall: 0.2.0
     blockdiag: 2.0.1
     certifi: 2020.6.20
     chardet: 3.0.4
     ChimeraX-AddH: 2.1.3
     ChimeraX-AlignmentAlgorithms: 2.0
     ChimeraX-AlignmentHdrs: 3.2
     ChimeraX-AlignmentMatrices: 2.0
     ChimeraX-Alignments: 2.1
     ChimeraX-Arrays: 1.0
     ChimeraX-Async: 0.1
     ChimeraX-Atomic: 1.6.1
     ChimeraX-AtomSearch: 2.0
     ChimeraX-AxesPlanes: 2.0
     ChimeraX-BasicActions: 1.1
     ChimeraX-BILD: 1.0
     ChimeraX-BlastProtein: 1.0.1
     ChimeraX-BondRot: 2.0
     ChimeraX-BugReporter: 1.0
     ChimeraX-BuildStructure: 2.0
     ChimeraX-Bumps: 1.0
     ChimeraX-BundleBuilder: 1.0
     ChimeraX-ButtonPanel: 1.0
     ChimeraX-CageBuilder: 1.0
     ChimeraX-CellPack: 1.0
     ChimeraX-Centroids: 1.1
     ChimeraX-ChemGroup: 2.0
     ChimeraX-Clashes: 2.0
     ChimeraX-Clipper: 0.15.0
     ChimeraX-ColorActions: 1.0
     ChimeraX-ColorGlobe: 1.0
     ChimeraX-CommandLine: 1.1.3
     ChimeraX-ConnectStructure: 2.0
     ChimeraX-Contacts: 1.0
     ChimeraX-Core: 1.1
     ChimeraX-CoreFormats: 1.0
     ChimeraX-coulombic: 1.0.1
     ChimeraX-Crosslinks: 1.0
     ChimeraX-Crystal: 1.0
     ChimeraX-DataFormats: 1.0
     ChimeraX-Dicom: 1.0
     ChimeraX-DistMonitor: 1.1
     ChimeraX-DistUI: 1.0
     ChimeraX-Dssp: 2.0
     ChimeraX-EMDB-SFF: 1.0
     ChimeraX-ExperimentalCommands: 1.0
     ChimeraX-FileHistory: 1.0
     ChimeraX-FunctionKey: 1.0
     ChimeraX-Geometry: 1.1
     ChimeraX-gltf: 1.0
     ChimeraX-Graphics: 1.0
     ChimeraX-Hbonds: 2.0
     ChimeraX-Help: 1.0
     ChimeraX-HKCage: 1.3
     ChimeraX-IHM: 1.0
     ChimeraX-ImageFormats: 1.0
     ChimeraX-IMOD: 1.0
     ChimeraX-IO: 1.0
     ChimeraX-ISOLDE: 1.1.0
     ChimeraX-Label: 1.0
     ChimeraX-LinuxSupport: 1.0
     ChimeraX-ListInfo: 1.0
     ChimeraX-Log: 1.1.1
     ChimeraX-LookingGlass: 1.1
     ChimeraX-Map: 1.0.1
     ChimeraX-MapData: 2.0
     ChimeraX-MapEraser: 1.0
     ChimeraX-MapFilter: 2.0
     ChimeraX-MapFit: 2.0
     ChimeraX-MapSeries: 2.0
     ChimeraX-Markers: 1.0
     ChimeraX-Mask: 1.0
     ChimeraX-MatchMaker: 1.1
     ChimeraX-MDcrds: 2.0
     ChimeraX-MedicalToolbar: 1.0.1
     ChimeraX-Meeting: 1.0
     ChimeraX-MLP: 1.0
     ChimeraX-mmCIF: 2.2
     ChimeraX-MMTF: 2.0
     ChimeraX-Modeller: 1.0
     ChimeraX-ModelPanel: 1.0
     ChimeraX-ModelSeries: 1.0
     ChimeraX-Mol2: 2.0
     ChimeraX-Morph: 1.0
     ChimeraX-MouseModes: 1.0
     ChimeraX-Movie: 1.0
     ChimeraX-Neuron: 1.0
     ChimeraX-Nucleotides: 2.0
     ChimeraX-OpenCommand: 1.2.1
     ChimeraX-PDB: 2.1
     ChimeraX-PDBBio: 1.0
     ChimeraX-Phenix: 0.1
     ChimeraX-PickBlobs: 1.0
     ChimeraX-Positions: 1.0
     ChimeraX-PresetMgr: 1.0
     ChimeraX-PubChem: 2.0
     ChimeraX-Read-Pbonds: 1.0
     ChimeraX-Registration: 1.1
     ChimeraX-RemoteControl: 1.0
     ChimeraX-ResidueFit: 1.0
     ChimeraX-RestServer: 1.0
     ChimeraX-RNALayout: 1.0
     ChimeraX-RotamerLibMgr: 2.0
     ChimeraX-RotamerLibsDunbrack: 2.0
     ChimeraX-RotamerLibsDynameomics: 2.0
     ChimeraX-RotamerLibsRichardson: 2.0
     ChimeraX-SaveCommand: 1.2
     ChimeraX-SchemeMgr: 1.0
     ChimeraX-SDF: 2.0
     ChimeraX-Segger: 1.0
     ChimeraX-Segment: 1.0
     ChimeraX-SeqView: 2.2
     ChimeraX-Shape: 1.0.1
     ChimeraX-Shell: 1.0
     ChimeraX-Shortcuts: 1.0
     ChimeraX-ShowAttr: 1.0
     ChimeraX-ShowSequences: 1.0
     ChimeraX-SideView: 1.0
     ChimeraX-Smiles: 2.0
     ChimeraX-SmoothLines: 1.0
     ChimeraX-SpaceNavigator: 1.0
     ChimeraX-StdCommands: 1.0.4
     ChimeraX-STL: 1.0
     ChimeraX-Storm: 1.0
     ChimeraX-Struts: 1.0
     ChimeraX-Surface: 1.0
     ChimeraX-SwapAA: 2.0
     ChimeraX-SwapRes: 2.0
     ChimeraX-TapeMeasure: 1.0
     ChimeraX-Test: 1.0
     ChimeraX-Toolbar: 1.0
     ChimeraX-ToolshedUtils: 1.0
     ChimeraX-Tug: 1.0
     ChimeraX-UI: 1.2.3
     ChimeraX-uniprot: 2.0
     ChimeraX-ViewDockX: 1.0
     ChimeraX-Vive: 1.1
     ChimeraX-VolumeMenu: 1.0
     ChimeraX-VTK: 1.0
     ChimeraX-WavefrontOBJ: 1.0
     ChimeraX-WebCam: 1.0
     ChimeraX-WebServices: 1.0
     ChimeraX-Zone: 1.0
     colorama: 0.4.3
     comtypes: 1.1.7
     cxservices: 1.0
     cycler: 0.10.0
     Cython: 0.29.20
     decorator: 4.4.2
     distlib: 0.3.1
     distro: 1.5.0
     docutils: 0.16
     filelock: 3.0.12
     funcparserlib: 0.3.6
     grako: 3.16.5
     graphviz: 0.14.1
     h5py: 2.10.0
     html2text: 2020.1.16
     idna: 2.10
     ihm: 0.16
     imagecodecs: 2020.5.30
     imagecodecs-lite: 2020.1.31
     imagesize: 1.2.0
     ipykernel: 5.3.0
     ipython: 7.15.0
     ipython-genutils: 0.2.0
     jedi: 0.17.2
     Jinja2: 2.11.2
     jupyter-client: 6.1.3
     jupyter-core: 4.6.3
     kiwisolver: 1.2.0
     line-profiler: 2.1.2
     lxml: 4.5.1
     MarkupSafe: 1.1.1
     matplotlib: 3.2.1
     msgpack: 1.0.0
     netifaces: 0.10.9
     networkx: 2.4
     numexpr: 2.7.1
     numpy: 1.18.5
     numpydoc: 1.0.0
     objgraph: 3.4.1
     openvr: 1.12.501
     packaging: 20.4
     ParmEd: 3.2.0
     parso: 0.7.1
     pexpect: 4.8.0
     pickleshare: 0.7.5
     Pillow: 7.1.2
     pip: 20.2.2
     pkginfo: 1.5.0.1
     prompt-toolkit: 3.0.7
     psutil: 5.7.0
     ptyprocess: 0.6.0
     pycollada: 0.7.1
     pydicom: 2.0.0
     Pygments: 2.6.1
     PyOpenGL: 3.1.5
     PyOpenGL-accelerate: 3.1.5
     pyparsing: 2.4.7
     PyQt5-commercial: 5.12.3
     PyQt5-sip: 4.19.19
     PyQtWebEngine-commercial: 5.12.1
     python-dateutil: 2.8.1
     pytz: 2020.1
     pyzmq: 19.0.2
     qtconsole: 4.7.4
     QtPy: 1.9.0
     RandomWords: 0.3.0
     requests: 2.24.0
     scipy: 1.4.1
     Send2Trash: 1.5.0
     SEQCROW: 0.24.3
     setuptools: 49.4.0
     sfftk-rw: 0.6.6.dev0
     six: 1.15.0
     snowballstemmer: 2.0.0
     sortedcontainers: 2.2.2
     Sphinx: 3.1.1
     sphinxcontrib-applehelp: 1.0.2
     sphinxcontrib-blockdiag: 2.0.0
     sphinxcontrib-devhelp: 1.0.2
     sphinxcontrib-htmlhelp: 1.0.3
     sphinxcontrib-jsmath: 1.0.1
     sphinxcontrib-qthelp: 1.0.3
     sphinxcontrib-serializinghtml: 1.1.4
     suds-jurko: 0.6
     tables: 3.6.1
     tifffile: 2020.6.3
     tinyarray: 1.2.2
     tornado: 6.0.4
     traitlets: 5.0.4
     urllib3: 1.25.10
     versioneer: 0.18
     wcwidth: 0.2.5
     webcolors: 1.11.1
     wheel: 0.34.2

 }}}

--
Ticket URL: <https://plato.cgl.ucsf.edu/trac/ChimeraX/ticket/4508>
ChimeraX <http://www.rbvi.ucsf.edu/chimerax/>
ChimeraX Issue Tracker

comment:2 by pett, 5 years ago

Cc: Greg Couch Elaine Meng added
Component: UnassignedDepiction
Owner: set to Tom Goddard
Platform: all
Project: ChimeraX
Status: newassigned
Summary: ChimeraX bug report submissionAdjust color brightness/contrast
Type: defectenhancement

in reply to:  3 ; comment:3 by Elaine Meng, 5 years ago

Hi Tristan, did you know about the "color modify" command?
<https://rbvi.ucsf.edu/chimerax/docs/user/commands/color.html#modify>

comment:4 by Tom Goddard, 5 years ago

The "color modify" command is supposed to do that, but I have never had much luck getting it to do what I want. The syntax is weird with leading plus signs and minus signs on numbers having special meaning. I agree some sliders to control this would be a lot more usable.

in reply to:  5 ; comment:5 by Elaine Meng, 5 years ago

Yes, and be careful because whether or not there is a space between the plus/minus sign and the number is meaningful.  Sliders would be useful, but people may not understand that there is hysteresis because (as I understood it) original color info is lost as you max out one component or another.  So simply sliding back to original position on slider may not return to the original color unless there is some kind of fancy smartness built in.

in reply to:  6 ; comment:6 by Tristan Croll, 5 years ago

The typical solution to the hysteresis problem in image editors is that the results are treated as a preview (as in, all values are calculated relative to the original colour(s)) until the user presses the OK button. That way there's no hysteresis while you're scrubbing up and down the slider searching for the perfect look - only with repeated uses of the tool.
________________________________
From: ChimeraX <ChimeraX-bugs-admin@cgl.ucsf.edu>
Sent: 14 April 2021 22:40
To: goddard@cgl.ucsf.edu <goddard@cgl.ucsf.edu>; Tristan Croll <tic20@cam.ac.uk>
Cc: meng@cgl.ucsf.edu <meng@cgl.ucsf.edu>; gregc@cgl.ucsf.edu <gregc@cgl.ucsf.edu>
Subject: Re: [ChimeraX] #4508: Adjust color brightness/contrast

#4508: Adjust color brightness/contrast
------------------------------------+-------------------------
          Reporter:  Tristan Croll  |      Owner:  Tom Goddard
              Type:  enhancement    |     Status:  assigned
          Priority:  normal         |  Milestone:
         Component:  Depiction      |    Version:
        Resolution:                 |   Keywords:
        Blocked By:                 |   Blocking:
Notify when closed:                 |   Platform:  all
           Project:  ChimeraX       |
------------------------------------+-------------------------

Comment (by Elaine Meng):

 {{{
 Yes, and be careful because whether or not there is a space between the
 plus/minus sign and the number is meaningful.  Sliders would be useful,
 but people may not understand that there is hysteresis because (as I
 understood it) original color info is lost as you max out one component or
 another.  So simply sliding back to original position on slider may not
 return to the original color unless there is some kind of fancy smartness
 built in.
 }}}

--
Ticket URL: <https://plato.cgl.ucsf.edu/trac/ChimeraX/ticket/4508#comment:5>
ChimeraX <http://www.rbvi.ucsf.edu/chimerax/>
ChimeraX Issue Tracker

in reply to:  7 ; comment:7 by goddard@…, 5 years ago

Yeah, the slider would hopefully be smart and not lose information.  The command loses the color info as the color components get clamped and that is what makes it not useful in the cases I tried to use it.  It is a bit tricky to remember all the original colors as they get adjusted, so this is not very easy to implement.

comment:8 by pett, 5 years ago

Seems to me that hardest part would be issuing the command equivalents.

comment:9 by pett, 5 years ago

Cc: pett added
Note: See TracTickets for help on using tickets.