Opened 9 years ago

Closed 8 years ago

#370 closed defect (fixed)

cannot go Back after going to external web pages

Reported by: Elaine Meng Owned by: Greg Couch
Priority: major Milestone: Initial Tools
Component: Help System Version:
Keywords: Cc: Conrad Huang
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

In the Qt version but not the Wx version, clicking a link to an external site such as this from the Quick Start:

Example structure: Protein DataBank
<a href="http://www.rcsb.org/pdb/explore.do?structureId=2bbv"
target="_blank">2BBV</a>, black beetle virus capsid

...gives a traceback (whereas in the Wx version it will show the page in your regular browser):

Traceback (most recent call last):
File "/Users/chimera/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/chimerax/help_viewer/gui.py", line 151, in createWindow
help_ui = HelpUI(self.session, self.bundle_info)
TypeError: init() missing 1 required positional argument: 'target'

Change History (9)

comment:1 by Greg Couch, 9 years ago

Got rid of the traceback, but the links still don't work.

comment:2 by Scooter Morris, 9 years ago

Milestone: Alpha Release

comment:3 by Conrad Huang, 9 years ago

Summary: links from Help viewer to external pages give traceback in Qt versioncannot go Back after going to external web pages

Link now works, but "Back" button does not work after visiting external link.

comment:4 by Elaine Meng, 9 years ago

Cc: Conrad Huang added

If I understand correctly this is not specifically from external links, but links encoded to open in a separate page (e.g. with target="_blank").

comment:5 by Conrad Huang, 9 years ago

Milestone: Alpha ReleaseInitial Tools
Status: newassigned

This will be fixed by implementing a tabbed browser interface for the help viewer. In the mean time, we should remove the "target" fields if going back is important. If target is left in place, the "Home" button should still get you back to the very initial page.

comment:6 by Elaine Meng, 8 years ago

Can't the page just be opened in the Help Viewer without obliterating the navigation history? I was willing to wait for tabs when I thought they might be implemented relatively soon, but it doesn't sound like that is going to happen.

comment:7 by Conrad Huang, 8 years ago

I believe opening new files in the help viewer no longer wipes history. The first page displayed is still set as the home page, though. Perhaps we should make "http://www.rbvi.ucsf.edu/chimerax/" the home page, regardless of which page is first displayed?

Tabs are still not implemented yet.

in reply to:  8 ; comment:8 by Elaine Meng, 8 years ago

It depends whether you want the help viewer home page to depend on the interwebs.  Some alternatives includes in the download are the documentation index or the User Guide index.

comment:9 by Greg Couch, 8 years ago

Resolution: fixed
Status: assignedclosed

Implemented tabbed browser, so external web pages get a new tab.

Note: See TracTickets for help on using tickets.