Opened 6 years ago

Closed 5 years ago

#2567 closed defect (fixed)

Command History window shown when it shouldn't be

Reported by: goddard@… Owned by: Eric Pettersen
Priority: normal Milestone:
Component: Command Line Version:
Keywords: Cc:
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

The following bug report has been submitted:
Platform:        Darwin-19.0.0-x86_64-i386-64bit
ChimeraX Version: 0.91 (2019-10-25)
Description
Command history window is showing when I click a mouse mode (new ViewDock mode), and when I click a file history thumbnail, and lots of other cases.

Putting in print statements in CommandLine.text_changed() shows that Command History is being shown every time by that routine.

    def text_changed(self, text):
        if text == self.show_history_label:
            self.cmd_clear()
            if not self._in_init:
                self.history_dialog.window.shown = True
                print ('hist show 2')


Log:
UCSF ChimeraX version: 0.91 (2019-10-25)  
© 2016-2019 Regents of the University of California. All rights reserved.  
How to cite UCSF ChimeraX  

> ui mousemode rightMode "next docking"

hist show 2  

> open /Users/goddard/ucsf/people/cruz/glide-test2.mae

hist show 2  
Opened glide-test2.mae containing 2 structures (13845 atoms, 14016 bonds)  
Chain information for glide-test2.mae  
---  
Chain | Description  
1.1/A | No description available  
1.1/B | No description available  
  




OpenGL version: 4.1 ATI-3.2.24
OpenGL renderer: AMD Radeon Pro Vega 20 OpenGL Engine
OpenGL vendor: ATI Technologies Inc.

Change History (3)

comment:1 by Eric Pettersen, 6 years ago

Component: UnassignedCommand Line
Owner: set to Eric Pettersen
Platform: all
Project: ChimeraX
Status: newaccepted
Summary: ChimeraX bug report submissionCommand History window shown when it shouldn't be

comment:2 by Eric Pettersen, 6 years ago

Still can't reproduce the problem using the actions you mentioned, but will look into the code you highlighted and will see if I can puzzle out what's going wrong (sometimes).

--Eric

comment:3 by Eric Pettersen, 5 years ago

Resolution: fixed
Status: acceptedclosed

I *believe* I fixed this on 2/21/2020 with commit 6e998ae0d7556b081b167fcd99910443bde5252c

Note: See TracTickets for help on using tickets.