Opened 6 years ago

Closed 6 years ago

#2330 closed defect (fixed)

Model Panel "close" button doesn't work

Reported by: Elaine Meng Owned by: Eric Pettersen
Priority: moderate Milestone:
Component: General Controls Version:
Keywords: Cc:
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

Commands like “close #!2” as automatically generated by the Close button in the Models panel do not close the models, I guess because they usually have submodels (volume displays, atomic model coordination pseudobonds or H-bonds, ...). Seems like the close button shouldn't use the exclamation point in the atomspec, right?

Change History (2)

comment:1 by Eric Pettersen, 6 years ago

Status: assignedaccepted

It's more like "close #!2" should close model 2 and its submodels rather than do nothing! (or at least generate an error/warning) T.G. and I are both of the opinion that it should close 2 and its submodels.

comment:2 by Eric Pettersen, 6 years ago

Resolution: fixed
Status: acceptedclosed

Well, it's turns out the the 'close' command explicitly avoids closing grouping models where not all the child models are also being closed. This is to avoid having e.g. 'close ~#1.1' close the #1 grouping model. Therefore reverted to using '#' instead of '#!' in the command generated by the model panel.

Note: See TracTickets for help on using tickets.