Markers GUI no longer needs to remove itself from registered state managers

[goddard@…]

The following bug report has been submitted:
Platform:        Darwin-18.6.0-x86_64-i386-64bit
ChimeraX Version: 0.91 (2019-06-29)
Description
Press Place Marker toolbar button under Right Mouse tab generates this error.

Log:
UCSF ChimeraX version: 0.91 (2019-06-29)  
© 2016-2019 Regents of the University of California. All rights reserved.  
How to cite UCSF ChimeraX  

> ui mousemode rightMode "place marker"

Traceback (most recent call last):  
File
"/Users/goddard/Desktop/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-
packages/chimerax/toolbar/tool.py", line 141, in <lambda>  
lambda e, what=what, self=self: self.handle_scheme(what),  
File
"/Users/goddard/Desktop/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-
packages/chimerax/toolbar/tool.py", line 93, in handle_scheme  
run(self.session, f'ui mousemode {button_to_bind} "{value}"')  
File
"/Users/goddard/Desktop/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-
packages/chimerax/core/commands/run.py", line 31, in run  
results = command.run(text, log=log)  
File
"/Users/goddard/Desktop/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-
packages/chimerax/core/commands/cli.py", line 2641, in run  
result = ci.function(session, **kw_args)  
File
"/Users/goddard/Desktop/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-
packages/chimerax/mouse_modes/cmd.py", line 69, in ui_mousemode  
mm.bind_mouse_mode(button, modifiers, mode)  
File
"/Users/goddard/Desktop/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-
packages/chimerax/mouse_modes/mousemodes.py", line 272, in bind_mouse_mode  
mode.enable()  
File
"/Users/goddard/Desktop/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-
packages/chimerax/markers/mouse.py", line 34, in enable  
p = marker_panel(self.session, 'Markers')  
File
"/Users/goddard/Desktop/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-
packages/chimerax/markers/markergui.py", line 150, in marker_panel  
session.remove_state_manager('_markers_gui')  
File
"/Users/goddard/Desktop/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-
packages/chimerax/core/session.py", line 466, in remove_state_manager  
del self._state_containers[tag]  
KeyError: '_markers_gui'  
  
KeyError: '_markers_gui'  
  
File
"/Users/goddard/Desktop/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-
packages/chimerax/core/session.py", line 466, in remove_state_manager  
del self._state_containers[tag]  
  
See log for complete Python traceback.  
  




OpenGL version: 4.1 ATI-2.9.26
OpenGL renderer: AMD Radeon Pro 580 OpenGL Engine
OpenGL vendor: ATI Technologies Inc.

[Tom Goddard]

Fixed.

Session code no longer registers attributes starting with underscorre "_" as state managers. This broke marker placement mouse mode which explicitly unregistered its gui as a state manager.