Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#199 closed defect (fixed)

closing STL opened from session file gives traceback

Reported by: Elaine Meng Owned by: Greg Couch
Priority: blocker Milestone:
Component: Sessions Version:
Keywords: Cc: Eric Pettersen, Conrad Huang, Tom Goddard
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

After restoring the attached session (just one STL model), command "close" gives traceback:
Traceback (most recent call last):
File "/Users/meng/Desktop/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/chimera/cmd_line/gui.py", line 121, in on_enter
cmd.execute()
File "/Users/meng/Desktop/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/chimera/core/commands/cli.py", line 1780, in execute
results.append(ci.function(session, kw_args))
File "/Users/meng/Desktop/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/chimera/core/commands/close.py", line 16, in close
m.close(models)
File "/Users/meng/Desktop/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/chimera/core/models.py", line 246, in close
m.delete()
File "/Users/meng/Desktop/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/chimera/core/models.py", line 52, in delete
delattr(self, "session")
AttributeError: session

Attachments (1)

test.cxs.gz (453.7 KB ) - added by Elaine Meng 10 years ago.

Download all attachments as: .zip

Change History (4)

by Elaine Meng, 10 years ago

Attachment: test.cxs.gz added

comment:1 by Greg Couch, 10 years ago

Resolution: fixed
Status: newclosed

Model wasn't getting session attribute restored. Reworked code to emphasis how restoring needs to initialize objects.

comment:2 by Elaine Meng, 10 years ago

Now I can close the STL opened from a session without traceback, thanks!

The display is not redrawn, however (looks like the structure is still there after it was closed) until you try to reposition it with the mouse. Don't know if it is a related bugette or something else.

comment:3 by Eric Pettersen, 10 years ago

Opening the out-of-sync redraw problem as a separate ticket

Note: See TracTickets for help on using tickets.