finish session molecular data save/restore

[Elaine Meng]

Until finished, molecular structure save/restore produces a traceback.

[pett]

Re-assigning to Conrad so that he can finish the Python-layer ribbon-related save/restore. I have placed comments in core/atomic/structure.py that start with "#RIBBON" describing the changes to make to actually initiate the save/restore of those values (currently they are simply set to their default values).

--Eric

[Conrad Huang]

I made a first pass using Python-level code to save ribbon attributes. Eric fixed it by moving the attribute-saving code into C++ where it belongs.

[pett]

Well, I only did Python->C++ for the attributes that I saw that Conrad had added to Python session saving. Namely:

ribbon orientation
show spline
tether shape
tether sides
mode helix
mode strand

Clearly there should be a bunch more (e.g. cross section). Either I missed where Conrad put them in the Python or Conrad didn't actually add them to session saving. Conrad?

[pett]

Oops, also moved:

tether scale
tether opacity

[pett]

Conrad sez he started with attributes that live in the C++ layer. So the Python-only attributes (such as cross section) haven't been done.

--Eric

[Conrad Huang]

The cross section stuff are now done. I didn't see any other ribbon-related attributes, but I'm leaving this ticket open so that someone can speak up in case I missed something.

[Elaine Meng]

If by cross-section stuff you mean only the xsection value, there’s also width and thickness that can be different for helix, strand, coil, and nucleic within a model, and the single-value per model settings: arrows (Bool), arrowsHelix (Bool), arrowScale, sides, barSides, barScale, see http://rbvi.ucsf.edu/chimerax/docs/user/commands/cartoon.html#style

I think Eric already listed all the tether stuff, though.

[Conrad Huang]

No.  cross section stuff includes all of that.  The "XSectionManager" 
class took care of converting all those parameters into a single set of 
coordinates for each type of cross section.  Eric helped me add the code 
to make XSectionManager instances (there is one for each structure) into 
sessions.

Conrad

On 2/23/2017 9:52 AM, Elaine Meng wrote: