improve/consolidate Medical Image icons to toggle mouse & hand-controller modes

[Elaine Meng]

Currently there are 4 icons, or actually 2 icons both appearing twice. As discussed, could be consolidated into 2 toggle icons, one for segmentations mouse modes and one for segmentations hand-controller modes, and also the images for these icons need to be simpler with thicker lines to make them legible at that small size. Or if you have decided they can't be consolidated from 4 to 2, should at least make the image improvements.

[Zach Pearson]

I've enlisted Chloe to create new icons for us and will replace the placeholders / write the code to update the toolbar labels when they're finished.

[Zach Pearson]

​Should be fixed.

[Elaine Meng]

These icons look great! Pass my kudos along to Chloe, if she made them. I only reopened this ticket because I wanted to verify: is what's in the current daily build the placement you wanted for these icons within the Medical Image toolbar? The actual mouse-mode icons are the grouping on the far right, so maybe this grouping could go just to the left of them if you want controller/mouse-related icons together. However, maybe it was a conscious decision to put them on the far left to make them more prominent, and that is also a reasonable decision especially for users in VR.

[Zach Pearson]

Oh, that's a bug. I mean for them to be on the far right - let me ask Eric and Greg why they think the toolbar placement is nondeterministic. I find that sometimes they're on the left and sometimes on the right.

[Elaine Meng]

I might also try to see if "Seg" can be wedged into the icon labels to clarify the function if the users aren't showing the group label, e.g.

Toggle Seg Mouse Modes
Toggle Seg Hand Modes

....but this can be vetoed if you dislike it and/or it doesn't fit the space.

[Zach Pearson]

Classifier: ChimeraX :: Bundle :: Volume Data :: 1,1 :: chimerax.segmentations ::  :: true
Classifier: ChimeraX :: Tool :: Segmentations :: Volume Data :: Interactively segment volumes
Classifier: ChimeraX :: Command :: ui view :: General :: See medical images in a 4-panel viewer
Classifier: ChimeraX :: Command :: segmentations :: Volume Data :: Create, edit, or destory segmentations
Classifier: ChimeraX :: Provider :: toggle mouse modes :: toolbar :: section:"Segmentation Controls" :: display_name:"Toggle Mouse Modes" :: after:"Mouse Mode" :: icon:mouse_small.png :: description:"Toggle mouse modes" :: tab:"Medical Image"
Classifier: ChimeraX :: Provider :: toggle hand modes :: toolbar :: section:"Segmentation Controls" :: after:"Mouse Mode" :: display_name:"Toggle Hand Modes" :: icon:right_controller_small.png :: description:"toggle hand modes" :: tab:"Medical Image"
Classifier: ChimeraX :: InitAfter :: manager :: ChimeraX-MouseModes :: ChimeraX-UI :: ChimeraX-MedicalToolbar

Can you see anything wrong with this metadata that would make the order nondeterministic?

[Greg Couch]

Is ChimeraX::InitAfter the same as setting a dependency in a bundle_info.xml file? If so, then it looks good, but I don't normally read the METADATA file.

[pett]

If I'm reading the Toolbar code right, "after" (and "before") only applies within the toolbar section. So after:"Mouse Mode" has no effect and the order of your toolbar buttons depends on the order that their provider lines get executed. I suggest that whichever one you want first be "before:" the other one.

[pett]

I see, you want the Segmentation Controls at the end. Try after:Windowing. I think before/after take buttons, not sections.

[Greg Couch]

before and after are at the same level. So tabs can be before/after other tabs, sections can be before/after other sections, and button can be before/after other buttons.

[pett]

So it seems Zach needs to make a provider declaration *just* for the Segmentation Controls section, similar to the first comment in toolbar.manager.add_provider()

[Zach Pearson]

I've resolved #15284 which unbeknownst to me was blocking this ticket. I estimate I see the reverse order buttons after at most 1 in 5 launches, so I opened ChimeraX 35 times in a row after reinstalling the medical toolbar and observed the correct ordering each time. If I have my probability correct, something with an 80% chance of occurring 35 times in a row is (0.8^{35)*100% or 0.04% so if this bug reappears we are in a very unlucky timeline.}