Opened 17 months ago

Closed 17 months ago

Last modified 17 months ago

#15284 closed defect (fixed)

TOML bundle builder doesn't generate metadata for toolbar sections

Reported by: Zach Pearson Owned by: Zach Pearson
Priority: moderate Milestone:
Component: Build System Version:
Keywords: Cc:
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

While trying to diagnose why my new toolbar section appears in the medical toolbar at a nondeterministic location, I compared the metadata generated for segmentations (a TOML bundle) to the metadata generated for the toolbar (an XML bundle), and discovered that the TOML file doesn't have an explicit tag for the toolbar section it creates. The XML bundle has tags like:

Classifier: ChimeraX :: Provider :: tab-right-mouse :: toolbar :: tab:"Right Mouse" :: after:"Markers" ...

but the TOML bundle only has the tags for buttons. I think this is probably the cause of the nondeterministic placement.

Change History (4)

comment:1 by pett, 17 months ago

Component: UnassignedBuild System

comment:2 by Zach Pearson, 17 months ago

Appears not to generate InitAfter either.

comment:3 by Zach Pearson, 17 months ago

Priority: blockermoderate

Not really a blocker

comment:4 by Zach Pearson, 17 months ago

Resolution: fixed
Status: assignedclosed

The format for TOML in toolbars is now

# ----------------- Toolbars -----------------
[chimerax.toolbar."Medical Image"]
after = "Map"
before = "Markers:Right Mouse"

[chimerax.toolbar."Medical Image".sections."File"]

[[chimerax.toolbar."Medical Image".sections."File".button]]
name = "open dicom"
display-name = "Open DICOM"
icon = "opendicom.png"
description = "Open DICOM directories"

[[chimerax.toolbar."Medical Image".sections."File".button]]
name = "recent"
link = "ChimeraX-Toolbar:Recent"

[[chimerax.toolbar."Medical Image".sections."File".button]]
name = "snapshot"
link = "ChimeraX-Shortcuts:sx"

[chimerax.toolbar."Medical Image".sections."Style"]
after = "File"

[[chimerax.toolbar."Medical Image".sections."Style".button]]
name="plane style"
link="ChimeraX-Shortcuts:pl"

[[chimerax.toolbar."Medical Image".sections."Style".button]]
name="slab style"
link="ChimeraX-Shortcuts:is"

which generates the metadata

Classifier: ChimeraX :: Provider :: tab-medical-image :: toolbar :: after:Map :: before:"Markers:Right Mouse" :: tab:"Medical Image"
Classifier: ChimeraX :: Provider :: section-file :: toolbar :: tab:"Medical Image" :: section:File
Classifier: ChimeraX :: Provider :: button-open-dicom :: toolbar :: display_name:"open dicom" :: icon:opendicom.png :: description:"Open DICOM directories" :: tab:"Medical Image" :: section:File
Classifier: ChimeraX :: Provider :: button-recent :: toolbar :: link:ChimeraX-Toolbar:Recent :: tab:"Medical Image" :: section:File :: display_name:recent
Classifier: ChimeraX :: Provider :: button-snapshot :: toolbar :: link:ChimeraX-Shortcuts:sx :: tab:"Medical Image" :: section:File :: display_name:snapshot
Classifier: ChimeraX :: Provider :: section-style :: toolbar :: after:File :: tab:"Medical Image" :: section:Style
Classifier: ChimeraX :: Provider :: button-plane-style :: toolbar :: link:ChimeraX-Shortcuts:pl :: tab:"Medical Image" :: section:Style :: display_name:"plane style"
Classifier: ChimeraX :: Provider :: button-slab-style :: toolbar :: link:ChimeraX-Shortcuts:is :: tab:"Medical Image" :: section:Style :: display_name:"slab style"
Last edited 17 months ago by Zach Pearson (previous) (diff)
Note: See TracTickets for help on using tickets.