![[ChimeraX Issue Tracking System]](/trac/ChimeraX/chrome/site/ChimeraX-icon.svg){kind=icon}
Opened 2 years ago
Closed 2 years ago
#9923 closed defect (fixed)
LookSee meeting incompatible version warning not shown
| Reported by: | Tom Goddard | Owned by: | Tom Goddard |
|---|---|---|---|
| Priority: | moderate | Milestone: | |
| Component: | VR | Version: | |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Notify when closed: | Platform: | all | |
| Project: | ChimeraX |
Description
The LookSee meeting check for incompatible LookSee versions does not work because neither the host nor the participant waits for the version checks on both sides to finish before sending and processing messages. So if the message format changes (I just changed the open new model message) then either party will get an error processing an incompatible message format before they get notified of the version incompatibility.
Seems like the version check has to be completed by both parties before either proceeds with sending or reading messages.
Note:
See TracTickets
for help on using tickets.
Fixed.
Made the code wait for the first message which must be the version message and then close the socket with an error message shown to the joining participant if the versions are incompatible. Tested with version 8 hosting meeting and version 9 joining or version 9 hosting and version 8 joining. Both worked.