Opened 3 years ago

Closed 10 months ago

Last modified 10 months ago

#8997 closed defect (fixed)

Skewed DICOM planes skew DICOM 2x2 view too

Reported by: Zach Pearson Owned by: Zach Pearson
Priority: moderate Milestone:
Component: DICOM Version:
Keywords: Cc:
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

Currently the experimental DICOM viewer positions the camera exactly along the X, Y, and Z axes, but it should optimally position them along the normals of the dicom planes, otherwise skewed datasets like 4D Lung won't be viewable.

Change History (6)

comment:1 by Eric Pettersen, 3 years ago

Component: Unassigned → DICOM

comment:2 by Scooter Morris, 2 years ago

Milestone: → 1.7

comment:3 by Tom Goddard, 2 years ago

Priority: blocker → moderate

comment:4 by Zach Pearson, 2 years ago

Milestone: 1.7

Demilestoning because as far as I've seen only the 4D lung dataset exhibits this skewed axis behavior.

comment:5 by Zach Pearson, 10 months ago

Resolution: → fixed
Status: assigned → closed

There's no reason that comes to mind to pay heed to the rotations of DICOM datasets, so the easier solution than calculating the axes the camera should point down is to just always use the identity matrix for rotation.

​https://github.com/RBVI/ChimeraX/commit/594f54cdee5b9fb3880b2b8a1210e838586ee8e6

comment:6 by Zach Pearson, 10 months ago

It would be the best solution of all to have one drawing whose texture changed according to the chosen slice, though.

Note: See TracTickets for help on using tickets.