Opened 3 years ago

Closed 3 years ago

#8688 closed defect (fixed)

TOML based bundles have stringly typed metadata

Reported by: Zach Pearson Owned by: Zach Pearson
Priority: high Milestone: 1.6
Component: UI Version:
Keywords: Cc:
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description (last modified by Zach Pearson)

I see that when a bundle uses TOML, variables like want_path, allow_directory, etc, become strings instead of booleans.

Change History (2)

comment:1 by Zach Pearson, 3 years ago

Description: modified (diff)
Priority: moderatehigh
Summary: NifTI and NRRD appear in Open DICOM dialog despite allow-directory=false in pyproject.tomlTOML based bundles have stringly typed metadata

comment:2 by Zach Pearson, 3 years ago

Resolution: fixed
Status: assignedclosed

https://github.com/RBVI/ChimeraX/commit/dc4e43d5c551cfb9de97a464633947a677ce17ba

Bundle default args used to be implied by default args to the functions that interpret metadata. Since those args are set by default in TOML bundle builder, they couldn't be the function defaults and needed to be converted.

Note: See TracTickets for help on using tickets.