cartoon style reporting needs improvement

[Elaine Meng]

UCSF ChimeraX version: 0.1 (2017-09-15)
OpenGL version: 4.1 NVIDIA-10.17.5 355.10.05.45f01
OpenGL renderer: NVIDIA GeForce GTX 675MX OpenGL Engine
OpenGL vendor: NVIDIA Corporation

I opened 1zik and then simply used "cartoon style" without changing anything beforehand. This gave the incorrect information that the helix mode was "tube" ... nope, it was default.

Then I used command "cartoon style x barbell" to change the cross-section to barbell and tried "cartoon style" again. Then it claimed helix mode was "wrap" and then gave a traceback.

Log contents:

cartoon style

1zik #1

• helix mode=tube xsection=round size=1,0.2 arrow=False arrow size=2,0.2,0.2,0.2
• strand mode=plank xsection=square size=1,0.2 arrow=True arrow size=2,0.2,0.2,0.2
• coil xsection=round size=0.2,0.2
• nucleic xsection=square size=0.2,1
• oval parameters: sides=12 faceted=False
• barbell parameters: sides=18 ratio=0.5 faceted=False

cartoon style xsection barbell
cartoon style

1zik #1

• helix mode=wrap xsection=piping size=1,0.2 arrow=False arrow size=2,0.2,0.2,0.2

Traceback (most recent call last):
File "/Users/chimera/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chimerax/cmd_line/tool.py", line 189, in execute
cmd.run(cmd_text)
File "/Users/chimera/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chimerax/core/commands/cli.py", line 2405, in run
result = ci.function(session, kw_args)
File "/Users/chimera/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chimerax/core/commands/cartoon.py", line 224, in cartoon_style
"mode=%s" % _ModeStrandInverseMap[mgr.style_helix],
KeyError: 2

KeyError: 2

File "/Users/chimera/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/site-packages/chimerax/core/commands/cartoon.py", line 224, in cartoon_style
"mode=%s" % _ModeStrandInverseMap[mgr.style_helix],

[Conrad Huang]

Fixed in 57a526628. Cut-and-paste error.

[Elaine Meng]

There are some other (less urgent) deficiencies, like reporting things that can no longer be changed with a command (faceted) and reporting half-dimensions instead of the full width and thickness shown.

[Elaine Meng]

Decrease priority as much as you want, but the style reporting really should be improved to parallel "cartoon style" command options, namely:

• remove stuff about faceting
• report actual width and thickness not "size" which is actually half-width, half-thickness
• arrowScale factor instead of actual arrow size (which confusingly shows 4 values now, even though the tip should always match the coil dimensions, and those 4 values are also half-dimensions)
• barScale or at least "scale" instead of "ratio" so people can tell what option controls it

[Conrad Huang]

Fixed in 45bce4348 and 8a06421ed