Opened 8 years ago

Closed 8 years ago

#833 closed enhancement (wontfix)

Allow Drawing.position (or positions) = None

Reported by: Tristan Croll Owned by: Tom Goddard
Priority: minor Milestone:
Component: Graphics Version:
Keywords: Cc:
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

Just because this seems a very Pythonic/intuitive way of handling the case where you temporarily want no instances of a Drawing visible, but attempting:

drawing.position = None
or
drawing.positions = None

leads to a crash of the graphics loop. I've accidentally done it a few times while trying out ideas, and cursed myself each time. I'm attaching the diffs to drawing.py and place.py that make it possible. Just a minor suggestion, no big deal either way.

Attachments (2)

place.py.diff​ (60 bytes ) - added by Tristan Croll 8 years ago.
drawing.py.diff​ (419 bytes ) - added by Tristan Croll 8 years ago.

Download all attachments as: .zip

Change History (5)

by Tristan Croll, 8 years ago

Attachment: place.py.diff​ added

by Tristan Croll, 8 years ago

Attachment: drawing.py.diff​ added

in reply to:  3 comment:1 by goddard@…, 8 years ago 

Wouldn't you say

	drawing.display = False

to temporarily hide a drawing?  I don't understand the use case for positions = None.

in reply to:  4 comment:2 by tic20@…, 8 years ago 

Yes, that's perfectly adequate as well - which is why I marked this as a 
minor suggestion. I just think it makes sense to minimise the number of 
ways a person can bork their session while experimenting.


On 2017-09-14 17:00, ChimeraX wrote:

comment:3 by Tom Goddard, 8 years ago

Resolution: → wontfix
Status: assigned → closed

Won't allow position = None because this places a burden on all code that needs to consider this case and has little benefit.

Note: See TracTickets for help on using tickets.