Opened 8 years ago

Closed 8 years ago

#826 closed defect (fixed)

Make ribbons use uint8 colors instead of float32

Reported by: Tom Goddard Owned by: Conrad Huang
Priority: major Milestone:
Component: Depiction Version:
Keywords: Cc:
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

Ribbon code is currently calculating the vertex colors as float32 values in 0-255 range. I'm surprised this works since the graphics code expects uint8 colors. Apparently the graphics code casts the current float32 values to uint8. It did break scene export code that was expecting uint8 colors.

The ribbon code should calculate vertex colors as uint8 when making the extrusion geometry.

I put in a quick fix that casts the float32 ribbon vertex colors to uint8 in structure.py.

Change History (1)

comment:1 by Conrad Huang, 8 years ago

Resolution: → fixed
Status: assigned → closed

Fixed in 3dc2ea602. Correctly treat ribbon colors as uint8 instead of floats.

Note: See TracTickets for help on using tickets.