Opened 3 years ago

Closed 3 years ago

#8109 closed defect (not a bug)

pyproject.toml-based "make install" should reinstall

Reported by: pett Owned by: Zach Pearson
Priority: moderate Milestone:
Component: Build System Version:
Keywords: Cc:
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

For bundle_info.xml-based bundles, "make install" forces a reinstall when the version number is the same (which is needed to test possible changes), but pyproject.toml-based bundles do not. The latter need to be changed to do the same as the former.

Change History (3)

comment:1 by Zach Pearson, 3 years ago

Is this behavior still present after your upgrade of setuptools? I looked at the TOML bundle builder code, and it has the same 'reinstall if versions are the same' logic that XML bunlde builder has.

As a sanity check, I installed alignment_headers, then removed all of its python source files except __init__.py and reinstalled it. I then listed out the bundle's directory in my developer build and the files I expected to be missing were missing.

in reply to:  2 ; comment:2 by pett, 3 years ago 

Hmm, the setuptools update got this working for pyproject.toml / alignment_headers.  Weird.  Anyway, that was an easy fix. :-)

comment:3 by Zach Pearson, 3 years ago

Resolution: → not a bug
Status: assigned → closed

Works for the version of setuptools shipped with 1.5 (and hopefully above whenever that distutils bug gets resolved).

Note: See TracTickets for help on using tickets.