Opened 3 years ago

Closed 3 years ago

#8034 closed defect (fixed)

"make clean" compiles bundle

Reported by: Greg Couch Owned by: Zach Pearson
Priority: blocker Milestone: 1.5
Component: Build System Version:
Keywords: Cc:
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

When doing "make clean" in the mmcif bundle with an error in src/mmcif.pyx, it tries to compile the .pyx file. It should not do that:

Executing: devel clean . exit true
Compiling src/mmcif.pyx because it changed.
[1/1] Cythonizing src/mmcif.pyx
warning: src\mmcif.pyx:176:66: Unreachable code

Error compiling Cython file:
------------------------------------------------------------
...
    models = [StructureClass(session, name=file_name, c_pointer=p, auto_style=auto_style, log_info=log_info)
              for p in pointers]

    for m in models:
        m.filename = path
        if combine_sym_atoms:
          ^
------------------------------------------------------------
...
}}}}

Change History (4)

comment:1 by pett, 3 years ago

Component: InfrastructureBuild System

comment:2 by Zach Pearson, 3 years ago

Found the bug and working on a fix. In core/commands/devel.py:_run, we pass in a reference to a bundle builder method but instantiate an object to use as its self parameter. When we instantiate the object, bundle builder expects to run, so it'll be a small refactor to set up a bundle without building it until asked to.

comment:3 by Zach Pearson, 3 years ago

Delayed the call to make_setup_arguments from init to the functions that need setup args e.g. make_wheel, make_editable_wheel; looks fixed but I'm testing a couple builds (once clean, once using devel clean then building).

comment:4 by Zach Pearson, 3 years ago

Resolution: fixed
Status: assignedclosed

Should be fixed by this patch for both develop and release/v1.5

Note: See TracTickets for help on using tickets.