Opened 3 years ago

Closed 3 years ago

#7218 closed defect (fixed)

PickedModel has no drawing() method

Reported by: chimerax-bug-report@… Owned by: Eric Pettersen
Priority: normal Milestone:
Component: Graphics Version:
Keywords: Cc: Tom Goddard
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description 

The following bug report has been submitted:
Platform:        macOS-10.16-x86_64-i386-64bit
ChimeraX Version: 1.5.dev202207020016 (2022-07-02 00:16:22 UTC)
Description
(Describe the actions that caused this problem to occur here)

Log:
Startup Messages  
---  
note | available bundle cache has not been initialized yet  
  
UCSF ChimeraX version: 1.5.dev202207020016 (2022-07-02)  
© 2016-2022 Regents of the University of California. All rights reserved.  
How to cite UCSF ChimeraX  

> open /Volumes/SSD1/CryoEM-projects/Cryo-nanocage/Gold_APO2/cryosparc-
> processing/cryosparc_P2_J677_010_volume_map_sharp.mrc

Opened cryosparc_P2_J677_010_volume_map_sharp.mrc as #1, grid size
420,420,420, pixel 1.1, shown at level 0.477, step 2, values float32  

> volume #1 step 1

> volume #1 level 0.6144

> volume #1 level 0.7668

> volume #1 level 0.8

> volume #1 level 0.84

> volume #1 level 0.85

> volume #1 level 0.86

Traceback (most recent call last):  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/core/updateloop.py", line 140, in _redraw_timer_callback  
self.session.ui.mouse_modes.mouse_pause_tracking()  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/mouse_modes/mousemodes.py", line 493, in
mouse_pause_tracking  
self._mouse_pause()  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/mouse_modes/mousemodes.py", line 628, in _mouse_pause  
m.pause(self._mouse_pause_position)  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/mouse_modes/std_modes.py", line 779, in pause  
p = self.view.picked_object(x, y)  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/graphics/view.py", line 802, in picked_object  
p = self.picked_object_on_segment(xyz1, xyz2, exclude = exclude, beyond =
beyond,  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/graphics/view.py", line 834, in picked_object_on_segment  
p = self.drawing.first_intercept(xyz1, xyz2, exclude=exclude)  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/core/models.py", line 125, in first_intercept  
pick = super().first_intercept(mxyz1, mxyz2, exclude=exclude)  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/graphics/drawing.py", line 1053, in first_intercept  
p = self.first_intercept_children(self.child_drawings(), mxyz1, mxyz2,
exclude=exclude)  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/graphics/drawing.py", line 1070, in first_intercept_children  
p = d.first_intercept(cxyz1, cxyz2, exclude=exclude)  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/map/volume.py", line 1112, in first_intercept  
d = pd.drawing()  
AttributeError: 'PickedModel' object has no attribute 'drawing'  
  
AttributeError: 'PickedModel' object has no attribute 'drawing'  
  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/map/volume.py", line 1112, in first_intercept  
d = pd.drawing()  
  
See log for complete Python traceback.  
  
Traceback (most recent call last):  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/mouse_modes/mousemodes.py", line 638, in <lambda>  
gw.mouseMoveEvent = lambda e, s=self: s._dispatch_mouse_event(e, "mouse_drag")  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/mouse_modes/mousemodes.py", line 537, in
_dispatch_mouse_event  
f(MouseEvent(event, modifiers=modifiers))  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/mouse_modes/std_modes.py", line 297, in mouse_drag  
self._rotate(axis, angle)  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/mouse_modes/std_modes.py", line 381, in _rotate  
self.view.rotate(saxis, angle, self.models())  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/graphics/view.py", line 998, in rotate  
center = self.center_of_rotation  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/graphics/view.py", line 679, in _get_cofr  
cofr = self._compute_center_of_rotation()  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/graphics/view.py", line 706, in _compute_center_of_rotation  
p = self._front_center_cofr()  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/graphics/view.py", line 774, in _front_center_cofr  
cr = self._front_center_point() # Can be None  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/graphics/view.py", line 783, in _front_center_point  
p = self.picked_object(0.5 * w, 0.5 * h, max_transparent_layers = 0,
exclude=View.unpickable)  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/graphics/view.py", line 802, in picked_object  
p = self.picked_object_on_segment(xyz1, xyz2, exclude = exclude, beyond =
beyond,  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/graphics/view.py", line 834, in picked_object_on_segment  
p = self.drawing.first_intercept(xyz1, xyz2, exclude=exclude)  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/core/models.py", line 125, in first_intercept  
pick = super().first_intercept(mxyz1, mxyz2, exclude=exclude)  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/graphics/drawing.py", line 1053, in first_intercept  
p = self.first_intercept_children(self.child_drawings(), mxyz1, mxyz2,
exclude=exclude)  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/graphics/drawing.py", line 1070, in first_intercept_children  
p = d.first_intercept(cxyz1, cxyz2, exclude=exclude)  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/map/volume.py", line 1112, in first_intercept  
d = pd.drawing()  
AttributeError: 'PickedModel' object has no attribute 'drawing'  
  
AttributeError: 'PickedModel' object has no attribute 'drawing'  
  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/map/volume.py", line 1112, in first_intercept  
d = pd.drawing()  
  
See log for complete Python traceback.  
  

> volume #1 level 0.88

> volume #1 level 0.89

> volume #1 level 0.9

> volume #1 level 1.1

> volume #1 level 1.2

> volume #1 level 1.3

> volume #1 level 1.4

> volume #1 level 1.5

> volume #1 level 1.6

Traceback (most recent call last):  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/core/updateloop.py", line 140, in _redraw_timer_callback  
self.session.ui.mouse_modes.mouse_pause_tracking()  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/mouse_modes/mousemodes.py", line 493, in
mouse_pause_tracking  
self._mouse_pause()  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/mouse_modes/mousemodes.py", line 628, in _mouse_pause  
m.pause(self._mouse_pause_position)  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/mouse_modes/std_modes.py", line 779, in pause  
p = self.view.picked_object(x, y)  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/graphics/view.py", line 802, in picked_object  
p = self.picked_object_on_segment(xyz1, xyz2, exclude = exclude, beyond =
beyond,  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/graphics/view.py", line 834, in picked_object_on_segment  
p = self.drawing.first_intercept(xyz1, xyz2, exclude=exclude)  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/core/models.py", line 125, in first_intercept  
pick = super().first_intercept(mxyz1, mxyz2, exclude=exclude)  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/graphics/drawing.py", line 1053, in first_intercept  
p = self.first_intercept_children(self.child_drawings(), mxyz1, mxyz2,
exclude=exclude)  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/graphics/drawing.py", line 1070, in first_intercept_children  
p = d.first_intercept(cxyz1, cxyz2, exclude=exclude)  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/map/volume.py", line 1112, in first_intercept  
d = pd.drawing()  
AttributeError: 'PickedModel' object has no attribute 'drawing'  
  
AttributeError: 'PickedModel' object has no attribute 'drawing'  
  
File
"/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.9/lib/python3.9/site-
packages/chimerax/map/volume.py", line 1112, in first_intercept  
d = pd.drawing()  
  
See log for complete Python traceback.  
  




OpenGL version: 4.1 Metal - 76.3
OpenGL renderer: Apple M1
OpenGL vendor: Apple

Python: 3.9.11
Locale: UTF-8
Qt version: PyQt6 6.3.1, Qt 6.3.1
Qt runtime version: 6.3.1
Qt platform: cocoa
Hardware:

    Hardware Overview:

      Model Name: MacBook Pro
      Model Identifier: MacBookPro17,1
      Processor Name: Unknown
      Processor Speed: 2.4 GHz
      Number of Processors: 1
      Total Number of Cores: 8
      L2 Cache: 8 MB
      Memory: 16 GB

Software:

    System Software Overview:

      System Version: macOS 12.4 (21F79)
      Kernel Version: Darwin 21.5.0
      Time since boot: 30 minutes

Graphics/Displays:

    Apple M1:

      Chipset Model: Apple M1
      Type: GPU
      Bus: Built-In
      Total Number of Cores: 8
      Vendor: Apple (0x106b)
      Metal Family: Supported, Metal GPUFamily Apple 7
      Displays:
        Color LCD:
          Display Type: Built-In Retina LCD
          Resolution: 2560 x 1600 Retina
          Main Display: Yes
          Mirror: Off
          Online: Yes
          Automatically Adjust Brightness: Yes
          Connection Type: Internal
        U28E570:
          Resolution: 3840 x 2160 (2160p/4K UHD 1 - Ultra High Definition)
          UI Looks like: 1920 x 1080 @ 30.00Hz
          Mirror: Off
          Online: Yes


Installed Packages:
    alabaster: 0.7.12
    appdirs: 1.4.4
    appnope: 0.1.3
    Babel: 2.10.3
    backcall: 0.2.0
    blockdiag: 3.0.0
    build: 0.7.0
    certifi: 2021.10.8
    cftime: 1.6.1
    charset-normalizer: 2.0.12
    ChimeraX-AddCharge: 1.2.3
    ChimeraX-AddH: 2.1.11
    ChimeraX-AlignmentAlgorithms: 2.0
    ChimeraX-AlignmentHdrs: 3.2.1
    ChimeraX-AlignmentMatrices: 2.0
    ChimeraX-Alignments: 2.5.1
    ChimeraX-AlphaFold: 1.0
    ChimeraX-AltlocExplorer: 1.0.2
    ChimeraX-AmberInfo: 1.0
    ChimeraX-Arrays: 1.0
    ChimeraX-Atomic: 1.39.5
    ChimeraX-AtomicLibrary: 7.0
    ChimeraX-AtomSearch: 2.0.1
    ChimeraX-AxesPlanes: 2.1
    ChimeraX-BasicActions: 1.1.1
    ChimeraX-BILD: 1.0
    ChimeraX-BlastProtein: 2.1.1
    ChimeraX-BondRot: 2.0
    ChimeraX-BugReporter: 1.0
    ChimeraX-BuildStructure: 2.7
    ChimeraX-Bumps: 1.0
    ChimeraX-BundleBuilder: 1.2
    ChimeraX-ButtonPanel: 1.0
    ChimeraX-CageBuilder: 1.0
    ChimeraX-CellPack: 1.0
    ChimeraX-Centroids: 1.2
    ChimeraX-CheckWaters: 1.0
    ChimeraX-ChemGroup: 2.0
    ChimeraX-Clashes: 2.2.4
    ChimeraX-ColorActions: 1.0
    ChimeraX-ColorGlobe: 1.0
    ChimeraX-ColorKey: 1.5.2
    ChimeraX-CommandLine: 1.2.3
    ChimeraX-ConnectStructure: 2.0.1
    ChimeraX-Contacts: 1.0
    ChimeraX-Core: 1.5.dev202207020016
    ChimeraX-CoreFormats: 1.1
    ChimeraX-coulombic: 1.3.2
    ChimeraX-Crosslinks: 1.0
    ChimeraX-Crystal: 1.0
    ChimeraX-CrystalContacts: 1.0
    ChimeraX-DataFormats: 1.2.2
    ChimeraX-Dicom: 1.1
    ChimeraX-DistMonitor: 1.1.6
    ChimeraX-Dssp: 2.0
    ChimeraX-EMDB-SFF: 1.0
    ChimeraX-ExperimentalCommands: 1.0
    ChimeraX-FileHistory: 1.0
    ChimeraX-FunctionKey: 1.0
    ChimeraX-Geometry: 1.2
    ChimeraX-gltf: 1.0
    ChimeraX-Graphics: 1.1
    ChimeraX-Hbonds: 2.2.1
    ChimeraX-Help: 1.2
    ChimeraX-HKCage: 1.3
    ChimeraX-IHM: 1.1
    ChimeraX-ImageFormats: 1.2
    ChimeraX-IMOD: 1.0
    ChimeraX-IO: 1.0.1
    ChimeraX-ItemsInspection: 1.0
    ChimeraX-Label: 1.1.1
    ChimeraX-ListInfo: 1.1.1
    ChimeraX-Log: 1.1.5
    ChimeraX-LookingGlass: 1.1
    ChimeraX-Maestro: 1.8.1
    ChimeraX-Map: 1.1
    ChimeraX-MapData: 2.0
    ChimeraX-MapEraser: 1.0
    ChimeraX-MapFilter: 2.0
    ChimeraX-MapFit: 2.0
    ChimeraX-MapSeries: 2.1
    ChimeraX-Markers: 1.0
    ChimeraX-Mask: 1.0
    ChimeraX-MatchMaker: 2.0.6
    ChimeraX-MDcrds: 2.6
    ChimeraX-MedicalToolbar: 1.0.1
    ChimeraX-Meeting: 1.0
    ChimeraX-MLP: 1.1
    ChimeraX-mmCIF: 2.7
    ChimeraX-MMTF: 2.1
    ChimeraX-Modeller: 1.5.6
    ChimeraX-ModelPanel: 1.3.4
    ChimeraX-ModelSeries: 1.0
    ChimeraX-Mol2: 2.0
    ChimeraX-Morph: 1.0
    ChimeraX-MouseModes: 1.1
    ChimeraX-Movie: 1.0
    ChimeraX-Neuron: 1.0
    ChimeraX-Nucleotides: 2.0.2
    ChimeraX-OpenCommand: 1.9
    ChimeraX-PDB: 2.6.6
    ChimeraX-PDBBio: 1.0
    ChimeraX-PDBLibrary: 1.0.2
    ChimeraX-PDBMatrices: 1.0
    ChimeraX-PickBlobs: 1.0
    ChimeraX-PIP: 0.1.0
    ChimeraX-Positions: 1.0
    ChimeraX-PresetMgr: 1.1
    ChimeraX-PubChem: 2.1
    ChimeraX-ReadPbonds: 1.0.1
    ChimeraX-Registration: 1.1
    ChimeraX-RemoteControl: 1.0
    ChimeraX-RenumberResidues: 1.1
    ChimeraX-ResidueFit: 1.0
    ChimeraX-RestServer: 1.1
    ChimeraX-RNALayout: 1.0
    ChimeraX-RotamerLibMgr: 2.0.1
    ChimeraX-RotamerLibsDunbrack: 2.0
    ChimeraX-RotamerLibsDynameomics: 2.0
    ChimeraX-RotamerLibsRichardson: 2.0
    ChimeraX-SaveCommand: 1.5.1
    ChimeraX-SchemeMgr: 1.0
    ChimeraX-SDF: 2.0
    ChimeraX-Segger: 1.0
    ChimeraX-Segment: 1.0
    ChimeraX-SelInspector: 1.0
    ChimeraX-SeqView: 2.7.1
    ChimeraX-Shape: 1.0.1
    ChimeraX-Shell: 1.0
    ChimeraX-Shortcuts: 1.1
    ChimeraX-ShowAttr: 1.0
    ChimeraX-ShowSequences: 1.0
    ChimeraX-SideView: 1.0
    ChimeraX-Smiles: 2.1
    ChimeraX-SmoothLines: 1.0
    ChimeraX-SpaceNavigator: 1.0
    ChimeraX-StdCommands: 1.8
    ChimeraX-STL: 1.0
    ChimeraX-Storm: 1.0
    ChimeraX-StructMeasure: 1.0.1
    ChimeraX-Struts: 1.0.1
    ChimeraX-Surface: 1.0
    ChimeraX-SwapAA: 2.0
    ChimeraX-SwapRes: 2.1.1
    ChimeraX-TapeMeasure: 1.0
    ChimeraX-Test: 1.0
    ChimeraX-Toolbar: 1.1.1
    ChimeraX-ToolshedUtils: 1.2.1
    ChimeraX-Tug: 1.0
    ChimeraX-UI: 1.21.1
    ChimeraX-uniprot: 2.2.1
    ChimeraX-UnitCell: 1.0
    ChimeraX-ViewDockX: 1.1.2
    ChimeraX-VIPERdb: 1.0
    ChimeraX-Vive: 1.1
    ChimeraX-VolumeMenu: 1.0
    ChimeraX-VTK: 1.0
    ChimeraX-WavefrontOBJ: 1.0
    ChimeraX-WebCam: 1.0
    ChimeraX-WebServices: 1.1.0
    ChimeraX-Zone: 1.0
    colorama: 0.4.4
    cxservices: 1.2
    cycler: 0.11.0
    Cython: 0.29.26
    debugpy: 1.6.0
    decorator: 5.1.1
    docutils: 0.17.1
    entrypoints: 0.4
    filelock: 3.4.2
    fonttools: 4.33.3
    funcparserlib: 1.0.0
    grako: 3.16.5
    h5py: 3.7.0
    html2text: 2020.1.16
    idna: 3.3
    ihm: 0.27
    imagecodecs: 2021.11.20
    imagesize: 1.4.1
    ipykernel: 6.6.1
    ipython: 7.31.1
    ipython-genutils: 0.2.0
    jedi: 0.18.1
    Jinja2: 3.0.3
    jupyter-client: 7.1.0
    jupyter-core: 4.10.0
    kiwisolver: 1.4.3
    line-profiler: 3.4.0
    lxml: 4.7.1
    lz4: 3.1.10
    MarkupSafe: 2.1.1
    matplotlib: 3.5.1
    matplotlib-inline: 0.1.3
    msgpack: 1.0.3
    nest-asyncio: 1.5.5
    netCDF4: 1.6.0
    networkx: 2.6.3
    numexpr: 2.8.3
    numpy: 1.22.1
    openvr: 1.16.802
    packaging: 21.0
    ParmEd: 3.4.3
    parso: 0.8.3
    pep517: 0.12.0
    pexpect: 4.8.0
    pickleshare: 0.7.5
    Pillow: 9.0.1
    pip: 21.3.1
    pkginfo: 1.8.2
    prompt-toolkit: 3.0.30
    psutil: 5.9.0
    ptyprocess: 0.7.0
    pycollada: 0.7.2
    pydicom: 2.2.2
    Pygments: 2.11.2
    PyOpenGL: 3.1.5
    PyOpenGL-accelerate: 3.1.5
    pyparsing: 3.0.9
    PyQt6-commercial: 6.3.1
    PyQt6-Qt6: 6.3.1
    PyQt6-sip: 13.4.0
    PyQt6-WebEngine-commercial: 6.3.1
    PyQt6-WebEngine-Qt6: 6.3.1
    python-dateutil: 2.8.2
    pytz: 2022.1
    pyzmq: 23.2.0
    qtconsole: 5.3.0
    QtPy: 2.1.0
    RandomWords: 0.3.0
    requests: 2.27.1
    scipy: 1.7.3
    setuptools: 62.6.0
    sfftk-rw: 0.7.2
    six: 1.16.0
    snowballstemmer: 2.2.0
    sortedcontainers: 2.4.0
    Sphinx: 4.3.2
    sphinx-autodoc-typehints: 1.15.2
    sphinxcontrib-applehelp: 1.0.2
    sphinxcontrib-blockdiag: 3.0.0
    sphinxcontrib-devhelp: 1.0.2
    sphinxcontrib-htmlhelp: 2.0.0
    sphinxcontrib-jsmath: 1.0.1
    sphinxcontrib-qthelp: 1.0.3
    sphinxcontrib-serializinghtml: 1.1.5
    tables: 3.7.0
    tifffile: 2021.11.2
    tinyarray: 1.2.4
    tomli: 2.0.1
    tornado: 6.2
    traitlets: 5.1.1
    urllib3: 1.26.9
    wcwidth: 0.2.5
    webcolors: 1.11.1
    wheel: 0.37.1
    wheel-filename: 1.3.0

Change History (10)

comment:1 by Eric Pettersen, 3 years ago

Cc: Tom Goddard added
Component: Unassigned → Graphics
Owner: set to Eric Pettersen
Platform: → all
Project: → ChimeraX
Status: new → accepted
Summary: ChimeraX bug report submission → PickedModel has no drawing() method

So the question is: should volume-picking code not be assuming that the returned object is a PickedTriangle and/or has a drawing() method, or should PickedModel have a drawing() method (in which case, the Pick class should probably say so).

in reply to:  2 ; comment:2 by goddard@…, 3 years ago 

I'm not sure why I did not require Pick to have a drawing method.  It is useful for any Pick to be able to tell which drawing it belongs to,  So I would definitely add that method to PickModel.  But it would require a survey of all the classes derived from Pick to see if there is some sane reason for not requiring it and to fix any that don't have it.

comment:3 by Eric Pettersen, 3 years ago

"Picked" classes that have a drawing() method:

  • PickedAtom
  • PickedBond
  • PickedResidue
  • PickedMap
  • PickedAtomicShape
  • PickedTriangle
  • PickedTriangles
  • PickedInstance

That don't:

  • PickedAtoms
  • PickedBonds
  • PickedPseudobond [seems like an outlier]
  • PickedPseudobonds
  • PickedResidues
  • PickedAtomicShapes [which does not inherit from Pick!]
  • PickedModel
Last edited 3 years ago by Eric Pettersen (previous) (diff)

in reply to:  4 ; comment:4 by Tom Goddard, 3 years ago 

Ok, I was afraid of that.  There are Pick classes that can represent multiple drawings and the drawing() method as it is currently used only returns a single drawing.  But it seems like every Pick class that can only represent a single drawing does offer the drawing() method and so I think PickedModel should too.

comment:5 by Eric Pettersen, 3 years ago

Any objection to my giving PickedPseudobond a drawing() method and having PickedAtomicShapes inherit from Pick while I'm at it?

Last edited 3 years ago by Eric Pettersen (previous) (diff)

in reply to:  6 ; comment:6 by Tom Goddard, 3 years ago 

Can't a pseudobond be between two different models?  I'm not sure what PickedAtomicShapes is but sounds like it should have a Pick base class.

comment:7 by Eric Pettersen, 3 years ago

Sure a pseudobond can be between two models, but isn't its drawing the pseudobond manager model?

comment:8 by Eric Pettersen, 3 years ago

Actually pseudobond group, not manager.

in reply to:  9 ; comment:9 by Tom Goddard, 3 years ago 

Yes.  Would be good to make the PickedPseudobond.drawing() return the PseudoBondGroup.

comment:10 by Eric Pettersen, 3 years ago

Resolution: → fixed
Status: accepted → closed

Okay, made the three changes that were being discussed.

Note: See TracTickets for help on using tickets.