Opened 3 years ago

Closed 3 years ago

#7159 closed enhancement (fixed)

Bump setuptools

Reported by: Zach Pearson Owned by: Zach Pearson
Priority: moderate Milestone:
Component: Build System Version:
Keywords: Cc: chimerax-programmers
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

Now that we no longer depend on suds, we're in a position where we can update setuptools.

I know of three issues:

  • in core/toolshed/installed.py: New versions of setuptools don't put "UNKNOWN" for no description, so we need to catch an AttributeError and set bi.description to "Missing bundle description"
  • When building bundles, setuptools complains that if it's imported after distutils it will monkey patch distutils so that the internal distutils is used
  • The import pip in core.__init__ breaks the build: see ​https://github.com/pypa/setuptools/issues/3044

Change History (5)

comment:1 by Zach Pearson, 3 years ago

Cc: chimerax-programmers added
Owner: set to Zach Pearson
Priority: blocker → moderate
Status: new → assigned
Type: defect → enhancement

comment:2 by Zach Pearson, 3 years ago

Component: Unassigned → Build System

comment:3 by Zach Pearson, 3 years ago

Could possibly test for os.path.join(site.getsitepackages(), "pip") instead of pip.__path__.

comment:4 by Zach Pearson, 3 years ago

Tested using the site method and all the bundles from the toolshed install on macOS. Will test Linux and Windows then merge if successful.

comment:5 by Zach Pearson, 3 years ago

Resolution: → fixed
Status: assigned → closed

Tested on Linux and Windows.

Using the new pip bundle, I was able to see that they were installed to the correct site packages directory.

Bumped setuptools to 62.6.0

Note: See TracTickets for help on using tickets.