Opened 8 years ago
Closed 8 years ago
#700 closed defect (fixed)
Toolshed dependency issue
Reported by: | Tristan Croll | Owned by: | Conrad Huang |
---|---|---|---|
Priority: | major | Milestone: | |
Component: | Tool Shed | Version: | |
Keywords: | Cc: | ||
Blocked By: | Blocking: | ||
Notify when closed: | Platform: | all | |
Project: | ChimeraX |
Description
My ISOLDE plugin is dependent upon my Clipper plugin. In the ISOLDE setup.py.in I have:
install_requires=[ "ChimeraX-Core >= 0.1", "ChimeraX-Clipper >= 0.1.0", # TODO: Should list numpy, OpenMM, simtk, etc. ],
... which works fine when I install locally using 'make app-install'. But when I attempt to upload ISOLDE to the Toolshed (after uploading the latest Clipper build without any apparent errors), I get:
The file you submitted has a problem app dependencies: dependency on "ChimeraX-Clipper": no such app exists.
I suspect there's a naming mismatch here - the Toolshed seems to enforce an underscore rather than a dash in the name. For now I've commented out the ChimeraX-Clipper line in ISOLDE's setup.py.in, since it's critical that I have the new version up for the weekend (I fly off to Erice early tomorrow morning and give a demo on Sunday, and want people to be able to download it for themselves). Would be good to get some clarification on this, though.
Change History (4)
comment:2 by , 8 years ago
This is still broken for me, but in a slightly different way. If I add the line:
<Dependency name="ChimeraX-Clipper" version=">=0.1"/>
... to the ISOLDE bundle.xml, then when trying to submit the bundle to the Toolshed I get:
The file you submitted has a problem app dependencies: dependency on "ChimeraX_Clipper" with version "0.1": no such release exists.
Note the underscore rather than the minus sign in the name. If I install the Clipper plugin from the toolshed, then its METADATA file reads:
Metadata-Version: 2.0 Name: ChimeraX-Clipper Version: 0.1.4 Summary: Interface to Kevin Cowtan's Clipper libraries Home-page: UNKNOWN Author: Tristan Croll Author-email: tic20@cam.ac.uk License: UNKNOWN Platform: UNKNOWN Classifier: Environment :: MacOS X :: Aqua Classifier: Environment :: Win32 (MS Windows) Classifier: Environment :: X11 Applications Classifier: Framework :: ChimeraX Classifier: Intended Audience :: Science/Research Classifier: License :: LGPL Classifier: Operating System :: MacOS :: MacOS X Classifier: Operating System :: Microsoft :: Windows :: Windows 10 Classifier: Operating System :: POSIX :: Linux Classifier: Programming Language :: Python :: 3 Classifier: Topic :: Scientific/Engineering :: Visualization Classifier: Topic :: Scientific/Engineering :: Chemistry Classifier: Topic :: Scientific/Engineering :: Bio-Informatics Classifier: Development Status :: 2 - Pre-Alpha Classifier: ChimeraX :: Bundle :: General :: 1,1 :: chimerax.clipper :: :: Requires-Python: >= 3.5 Requires-Dist: ChimeraX-Core (>=0.1)
comment:3 by , 8 years ago
Status: | assigned → feedback |
---|
Hi, Tristan.
Sorry about the late response. Working on mysterious Linux daily build failure.
Can you please send me the two wheels for Clipper and ISOLDE? I'll try to reproduce the problem on our test site. Thanks.
Conrad
comment:4 by , 8 years ago
Resolution: | → fixed |
---|---|
Status: | feedback → closed |
Fixed in 79500db. The toolshed code was expecting an exact match for the bundle version in the dependency, even when ">=" is present. Code is now updated to handle ">=" properly. In fact, only ">=" is supported right now.