Opened 3 years ago

Closed 3 years ago

#6922 closed task (fixed)

Update core setup.py to pyproject.toml

Reported by: Zach Pearson Owned by: Zach Pearson
Priority: moderate Milestone: 1.6
Component: Build System Version:
Keywords: Cc: chimerax-programmers
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

Will start this effort in an isolated branch with no other changes and report back what I find for discussion.

Change History (6)

comment:1 by Eric Pettersen, 3 years ago

Component: Unassigned → Build System

comment:2 by Zach Pearson, 3 years ago

Component: Build System → Unassigned

Good news: it's not hard to build core with native tooling, using ChimeraX's internal Python. It can be accomplished with three new dependencies in app_requirements.txt: tomli ; python_version < 3.11 , build, and pep517. These can be installed without breaking our current requirement on setuptools 59.

That would appear to be a contradiction, since setuptools 59 doesn't support this build scheme. However, since build immediately creates an isolated environment in which to build the package and assembles its build requirements from the internet, each subpackage of ChimeraX can depend on different versions and would -- based on this finding -- no longer be constrained by the build requirements of another submodule.

Would seem to suggest we can update bundles piecewise.

comment:3 by Zach Pearson, 3 years ago

Component: Unassigned → Build System

comment:4 by Zach Pearson, 3 years ago

​Feel free to review this PR.

We should establish some minimal formal process for reviews later on.

comment:5 by Zach Pearson, 3 years ago

Milestone: 1.5 → 1.6

Moving to 1.6

comment:6 by Zach Pearson, 3 years ago

Resolution: → fixed
Status: assigned → closed

Implemented in a series of commits including primarily ​this one.

Note: See TracTickets for help on using tickets.