Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#5529 closed task (fixed)

Remove lineprofiler from prereqs

Reported by: Tom Goddard Owned by: Tom Goddard
Priority: moderate Milestone:
Component: Infrastructure Version:
Keywords: Cc: chimerax-programmers
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

I think we can git remove the prereqs/lineprofiler directory. It is not currently used. Binary wheels for PyPi lineprofiler are available. This is something developers can optionally pip install into ChimeraX when needed.

Begin forwarded message:

From: Tom Goddard
Subject: Re: [GitHub] Your Dependabot alerts for the week of Oct 26 - Nov 2
Date: November 2, 2021 at 8:05:05 PM PDT
To: Eric Pettersen , Zach Pearson
Cc: Gregory Couch

It appears that lineprofiler 3.3.1 on PyPi is available as binary wheels for Python 3.9 for Windows, Mac and Linux. So I think we could get rid of prereqs/lineprofiler and put it in prereqs/pips/app_requirements.txt commented out for installation when a developer wants it. Or better when the "devel install lineprofiler" command is working for installing pypi packages from a ChimeraX command that can be used to get it.

Tom

On Nov 2, 2021, at 4:32 PM, Eric Pettersen wrote:

lineprofiler is for the --lineprofile option. Because it is difficult to get to automatically build on Windows(?) you have to install it by hand to use it, but in some situations it is pretty handy.

--Eric

On Nov 2, 2021, at 4:28 PM, Zach Pearson wrote:

I have about the same question, but with prereqs/lineprofiler

— Zach

Change History (5)

in reply to:  1 ; comment:1 by Greg Couch, 4 years ago

Yes we can remove the lineprofiler directory.  It was for an old version 
that we hacked to compile on all platforms.  We switched to a newer 
version via prereqs/pips/app_requirements.txt.  It was limited it to 
linux because there were only linux binaries when we switched to the 
newer version.  Now that there are binaries for all platforms, we should 
re-enable it.

comment:2 by Tom Goddard, 4 years ago

Resolution: fixed
Status: assignedclosed

Removed prereqs/lineprofiler.

in reply to:  3 ; comment:3 by Eric Pettersen, 4 years ago

Can we have the --lineprofile option somehow do the install if needed?


in reply to:  4 ; comment:4 by goddard@…, 4 years ago

I think that is possible but we need the basic capability to pip install a package from a ChimeraX command or from Python run by ChimeraX and that is ticket #4762 milestoned for 1.3.  I think we should take this approach of install when first used for other tools that use especially big and rarely used stuff like pydicom.

comment:5 by Eric Pettersen, 3 years ago

Now that the "devel pip" command exists, we could have the --lineprofile option do the needed pip install.

Note: See TracTickets for help on using tickets.