Blast Protein "Default" button does not restore columns previously specified with "Set Default"

[Elaine Meng]

In today's daily build UCSF ChimeraX version: 1.3.dev202110060041 (2021-10-06)

Tested with blast protein results from searching alphafold. If I change the set of columns shown by using individual checkboxes, then click "Set Default", then click "Default" it goes back to the same as the "Standard" set. It does not go back to the set that were shown when I clicked "Save Default." I don't know if that is a failure to save the defaults as a preference or to restore the defaults that were saved as a preference.

Also occurred to me that there are different columns for alphafold and pdb/nr, so not sure whether/how that will work with the user defaults. Maybe there are defaults separately saved for those two cases, depending on what is in the results dialog at the time?

[pett]

I believe this is a problem with the table widget itself rather than how Zach is using the widget, so reassigning to myself.

For each type of search to remember a different set of default columns, the table would have to be constructed with a different settings object for each -- which would be a Zach thing.

[pett]

Fixed the problem where 'Default' was restoring the standard columns.

I don't know if the different-search-types-need-different-results thing is actually a problem or not. It would depend on Zach's code. If it is a problem, make a new ticket because I'm closing this one...

[pett]

..-need-different-defaults thing...

[Elaine Meng]

Tests suggest there is just one set of defaults.  If they include some PDB-only set of columns but you search AlphaFold, it just shows the subset that are present, which seems fine to me.  I haven't tested defaults extensively, but all seems OK in various spot tests, so I'll trust that it works.