Opened 9 years ago

Closed 9 years ago

#392 closed defect (fixed)

"round" ribbon (cartoon) normals may be wrong

Reported by: Elaine Meng Owned by: Conrad Huang
Priority: major Milestone:
Component: Depiction Version:
Keywords: Cc:
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

Maybe there's a bug making the ribbons look too fat and bulgy, see attached image showing a comparison between Chimera and ChimeraX ribbons with same width and thickness. I suspected the normals because we had the same problem in Chimera for years. Tom Goddard said: in Chimera 1 the issue was that the ellipse ribbon cross-section was using normal vectors that were appropriate for a circle — the ribbon thickness scaling wasn’t adjusting the normal vectors.

Attachments (1)

screenshot-compare-ribbons.png (620.1 KB ) - added by Elaine Meng 9 years ago.

Download all attachments as: .zip

Change History (2)

by Elaine Meng, 9 years ago

comment:1 by Conrad Huang, 9 years ago

Resolution: fixed
Status: newclosed

There was indeed a bug, and is fixed in 17a02c6.

When an oval cross section is created by scaling, the coordinates were properly scaled but the normals were not. Once scaled, the ribbons look a lot skinnier.

Note: See TracTickets for help on using tickets.