Molecule Display toolbar icons in different orders, sometimes nucleotides before others

[Elaine Meng]

See attached screenshots showing the Molecule Display tool with ChimeraX version numbers shown in Log. In the daily build screenshot the nuc-style icon is to the left of the stick/sphere/ball icons, and the nuc-color icon is to the left of the other coloring icons. In the release candidate screenshot they are after the others within the respective sections (style, coloring).

[Elaine Meng]

earlier in the day I could have sworn it was the other way around, although the two versions were still different, so maybe it is a semirandom thing depending on when the nucleotides bundle is started

[Greg Couch]

The ordering must be under specified. I'll look into it.

[Greg Couch]

Eric, will the recent provider changes, is there any chance that the providers could be added in a different order than how they appear in the bundle.xml file?

[Greg Couch]

will -> with

[pett]

There is no specific order that add_provider is called for providers within a bundle, and there's _really_ no order for providers coming from different bundles. Typically when I need providers ordered, either the manager imposes an order (e.g. alphabetization) or the providers include ordering information in their Provider tags (e.g. preset providers have an order="number" tag attribute) which is passed into the add_provider call. The manager then typically puts the providers in order during the end_providers call.

It occurs to me that the toolbar manager could be converted into a lazy manager, but that would only be a "win" in the 0.0001% case where the user has turned off autostart of the Toolbar tool -- so really not worth the effort.

[Greg Couch]

I was depending on the previous behavior where the providers were registered in the order that they were given in the bundle.xml file. Will add constraints.

[pett]

AFAIK, I didn't change anything in that regard. On the other hand, it was just side-effect behavior, so you shouldn't depend on it for sure.