Opened 5 years ago

Closed 5 years ago

#3256 closed defect (fixed)

ViewDockX save broken

Reported by: pett Owned by: Conrad Huang
Priority: normal Milestone:
Component: Surface/Binding Analysis Version:
Keywords: Cc:
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description (last modified by pett)

The following bug report has been submitted:
Platform:        Darwin-18.7.0-x86_64-i386-64bit
ChimeraX Version: 1.0rc202005190042 (2020-05-19 00:42:41 UTC)
Description
Trying to "Save" in ViewDockX.  It seems that the 'saved_output' attribute of OutputCache is only set when the underlying stream is closed, but is accessed while the stream is still open.  Noticed this as I was updating SaveDialog to not use old code, so you may need to pull latest changes.

Log:
UCSF ChimeraX version: 1.0rc202005190042 (2020-05-19)  
© 2016-2020 Regents of the University of California. All rights reserved.  
How to cite UCSF ChimeraX  

> open /Users/pett/src/chimerax/docs/user/formats/dock4.mol2 format mol2

Opened dock4.mol2 containing 30 structures (744 atoms, 763 bonds)  

> ui tool show ViewDockX

Traceback (most recent call last):  
File
"/Users/pett/src/chimerax/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-
packages/chimerax/ui/gui.py", line 604, in customEvent  
func(*args, **kw)  
File
"/Users/pett/src/chimerax/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-
packages/chimerax/viewdockx/tool.py", line 380, in handle_scheme  
method(query)  
File
"/Users/pett/src/chimerax/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-
packages/chimerax/viewdockx/tool.py", line 482, in _cb_export  
print(sf.saved_output, end='', file=outf)  
AttributeError: 'OutputCache' object has no attribute 'saved_output'  
  
AttributeError: 'OutputCache' object has no attribute 'saved_output'  
  
File
"/Users/pett/src/chimerax/ChimeraX.app/Contents/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-
packages/chimerax/viewdockx/tool.py", line 482, in _cb_export  
print(sf.saved_output, end='', file=outf)  
  
See log for complete Python traceback.  
  




OpenGL version: 4.1 INTEL-12.10.16
OpenGL renderer: Intel(R) Iris(TM) Pro Graphics 6200
OpenGL vendor: Intel Inc.Hardware:

    Hardware Overview:

      Model Name: iMac
      Model Identifier: iMac16,2
      Processor Name: Intel Core i5
      Processor Speed: 2.8 GHz
      Number of Processors: 1
      Total Number of Cores: 4
      L2 Cache (per Core): 256 KB
      L3 Cache: 4 MB
      Memory: 16 GB
      Boot ROM Version: 232.0.0.0.0
      SMC Version (system): 2.32f20

Software:

    System Software Overview:

      System Version: macOS 10.14.6 (18G3020)
      Kernel Version: Darwin 18.7.0
      Time since boot: 9:41

Graphics/Displays:

    Intel Iris Pro Graphics 6200:

      Chipset Model: Intel Iris Pro Graphics 6200
      Type: GPU
      Bus: Built-In
      VRAM (Dynamic, Max): 1536 MB
      Vendor: Intel
      Device ID: 0x1622
      Revision ID: 0x000a
      Metal: Supported, feature set macOS GPUFamily1 v4
      Displays:
        iMac:
          Display Type: LCD
          Resolution: 1920 x 1080 (1080p FHD - Full High Definition)
          UI Looks like: 1920 x 1080
          Framebuffer Depth: 30-Bit Color (ARGB2101010)
          Main Display: Yes
          Mirror: Off
          Online: Yes
          Rotation: Supported
          Automatically Adjust Brightness: No
          Connection Type: DisplayPort

PyQt version: 5.12.3
Compiled Qt version: 5.12.4
Runtime Qt version: 5.12.8

Change History (3)

comment:1 by pett, 5 years ago

Component: UnassignedSurface/Binding Analysis
Owner: set to Conrad Huang
Platform: all
Project: ChimeraX
Status: newassigned
Summary: ChimeraX bug report submissionViewDockX save broken

comment:2 by pett, 5 years ago

Description: modified (diff)

comment:3 by Conrad Huang, 5 years ago

Resolution: fixed
Status: assignedclosed

Fixed in 1baab4c05.

Some code got indented too far and ended up inside the "with" statement instead of outside.

Note: See TracTickets for help on using tickets.