#3056 closed defect (fixed)
ISOLDE's ToolShed entry broken
Reported by: | Tristan Croll | Owned by: | Greg Couch |
---|---|---|---|
Priority: | blocker | Milestone: | |
Component: | Tool Shed | Version: | |
Keywords: | Cc: | Conrad Huang, pett | |
Blocked By: | Blocking: | ||
Notify when closed: | Platform: | all | |
Project: | ChimeraX |
Description
I'm afraid I just broke ISOLDE's ToolShed entry by uploading a bundle with a version string it doesn't like (1.0b5.1). Going to https://cxtoolshed.rbvi.ucsf.edu/apps/chimeraxisolde now just gives me a traceback page with InvalidVersion
.
(a) Could you delete the offending bundle?
(b) What would be an acceptable version string? 1.0b5.post1 looks like the most PEP 440 compliant option? I know it's discouraged, but I'd like to stick with the current system of "new ISOLDE beta goes with new ChimeraX numeric version".
Change History (4)
comment:1 by , 6 years ago
Cc: | added; removed |
---|---|
Owner: | changed from | to
comment:2 by , 6 years ago
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
The 1.0b5.1 has been removed. Will change bundle submission code to require that the version be legal.
FYI, pip doesn't like prereleases that much, by default they are not found when pip is searching for dependencies. So for the versions of ISOLDE that are matched to ChimeraX releases, it would be best if you dropped the beta suffix.
follow-up: 3 comment:3 by , 6 years ago
I've been trying to avoid taking the plunge to ISOLDE 1.0 until ChimeraX does (would seem strange to have a plugin that's 1.0 when the platform isn't). Perhaps I should have just stuck with 0.x.y, but I suppose it's too late now. Not sure if it's so important, though? ISOLDE isn't a dependency for anything else (yet), and the Clipper bundle that ISOLDE depends on *is* still on a 0.x.y scheme. On 2020-04-16 17:02, ChimeraX wrote:
comment:4 by , 6 years ago
Bundles will now be rejected when submitted if it has an invalid version number.
And "devel build" and "devel install" won't build the bundle in the first place if the version is invalid.
Greg is managing the toolshed now with help from Conrad.