Installing bundle doesn't add its providers

[Eric Pettersen]

So when checking my updates to the developer tutorials, I noted that installing the "read-a-file" bundle did not add its provider. Restarting ChimeraX caused the provider to show up. Methinks the provider should be added when the bundle gets installed, or are we anticipating always having to restart bundles after installation if they participate in any manager/provider protocols? With open2/save2, bundles adding providers is going to be a lot more widespread...

Just FYI, you can try it out yourself with:

devel build your-chimerax-parent/chimerax/src/examples/tutorials/tut_read
devel install your-chimerax-parent/chimerax/src/examples/tutorials/tut_read

The add_provider is in open_command/src/manager.py

[Eric Pettersen]

Is this because I'm using "devel install"? Would(/should) "toolshed install" run the provider?

[Conrad Huang]

I think so.  "devel install" just installs the wheel from file, while 
"toolshed install" uses pip.  There is code in install_bundle() to run 
_init_bundle_manager() unless in safe mode.  Maybe we should look at 
changing "devel install" to "devel build" followed by "toolshed install".

On 4/9/2020 9:36 AM, ChimeraX wrote:

[Eric Pettersen]

I don't see anything in install_bundle() that makes the bundle's providers available to the relevant managers.

[Conrad Huang]

You're right.  That's the complement to the case that is handled, where 
the new bundle's manager gets its providers from relevant bundles. 
There needs to be another section in install_bundle() to propagate the 
new providers out.

On 4/9/2020 2:08 PM, ChimeraX wrote:

[Eric Pettersen]

So....

Are you going to do this? If you're overwhelmed I could take a stab at it, with an extreme amount of trepidation...

[Conrad Huang]

I probably can't get to it for a couple days, so feel free to take a 
swing at it.

Conrad

On 4/10/2020 3:36 PM, ChimeraX wrote:

[Eric Pettersen]

So I looked into this (getting newly installed bundles to notify managers about providers) and the main stumbling block is that the toolshed does not retain any list of the managers it initializes, so it's impossible to notify the manager later about new providers. Is there any reason I shouldn't remember initialized manager instances?

If there isn't, I can run with that...

[Conrad Huang]

I think the original reasoning was that the bundles are responsible for 
registering their managers in the current session, back when managers 
were much more limited.  So there was going to be a way to get all the 
managers from the session.  Now that managers that do not need to be 
saved in sessions no longer need to be registered, I think having the 
toolshed keep track of a complete list is quite reasonable.  Might want 
to use weak references, although that may not make any difference.

On 4/22/2020 3:42 PM, ChimeraX wrote: