Opened 6 years ago

Closed 5 years ago

#2830 closed defect (fixed)

Allow Toolshed uploads with dependencies on daily build bundles

Reported by: goddard@… Owned by: Greg Couch
Priority: normal Milestone:
Component: Tool Shed Version:
Keywords: Cc: Conrad Huang, pett
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description (last modified by Tom Goddard)

The following bug report has been submitted:
Platform:        Windows-10-10.0.17763
ChimeraX Version: 0.92 (2020-01-22)
Description
Toolshed won't allow uploading a new bundle version with a dependency on a bundle that is included in the daily build but is not on the toolshed.  I am trying to upload the realsense bundle that has a dependency of the vive bundle and get the following error in the ChimeraX Toolshed "Submit a Bundle" web page "The file you submitted problem with dependencies: missing dependency "Vive": bundle not on toolshed. "

This error should probably be a warning when uploading the bundle.  When the user tries to install the bundle it will of course check the dependency in the users ChimeraX which will be present as it is included in daily builds.

Log:
UCSF ChimeraX version: 0.92 (2020-01-22)  
© 2016-2020 Regents of the University of California. All rights reserved.  
How to cite UCSF ChimeraX  

Expected a collection of one of 'atoms', 'bonds', 'cartoons', 'models',
'pbonds', 'pseudobonds', 'ribbons', or 'surfaces' or a keyword  




OpenGL version: 3.3.0 NVIDIA 430.39
OpenGL renderer: Quadro P6000/PCIe/SSE2
OpenGL vendor: NVIDIA Corporation

Change History (3)

comment:1 by Tom Goddard, 6 years ago

Cc: Greg Couch added
Component: UnassignedTool Shed
Description: modified (diff)
Owner: set to Conrad Huang
Platform: all
Project: ChimeraX
Status: newassigned
Summary: ChimeraX bug report submissionAllow Toolshed uploads with dependencies on daily build bundles

For the moment I've worked around this problem by removing the dependency on the Vive bundle from the RealSense bundle -- not ideal since people will get the RealSense bundle with an older ChimeraX daily build and the new features won't work correctly.

comment:2 by Conrad Huang, 5 years ago

Owner: changed from Conrad Huang to Greg Couch

We can ignore the dependencies and allow the bundle to be created on the toolshed. However, we need to make sure that the pip server part of toolshed uses the dependencies listed in the bundles themselves and not data from the objects in the Django model. If the latter is used, then pip will not get the required dependencies correct.

comment:3 by Greg Couch, 5 years ago

Cc: Conrad Huang pett added; Greg Couch removed
Resolution: fixed
Status: assignedclosed

Dependency check no longer prevents bundle submission.

Note: See TracTickets for help on using tickets.