Opened 6 years ago

Closed 5 years ago

#2828 closed defect (fixed)

Rotamer dialog column sorting not numerical

Reported by: Elaine Meng Owned by: Eric Pettersen
Priority: major Milestone:
Component: Structure Analysis Version:
Keywords: Cc:
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

If I calculate clashes for Arg rotamers at 3gws residue 346 (Leu) and then sort on the clashes column, it thinks 8 is larger than 38, for example (image attached). It may never be seen for the hbonds since one rotamer is unlikely to make >9 hbonds.

Attachments (1)

Screen Shot 2020-02-10 at 3.06.37 PM.png​ (95.2 KB ) - added by Elaine Meng 6 years ago.

Download all attachments as: .zip

Change History (3)

by Elaine Meng, 6 years ago

Attachment: Screen Shot 2020-02-10 at 3.06.37 PM.png​ added

comment:1 by Eric Pettersen, 6 years ago

Status: assigned → accepted

Need to get underlying table widget to support numeric sorting by subclassing QSortProxyModel and overriding lessThan(). Also need to add support to _ItemColumn (explicit 'numeric' attr and/or custom sort func)

comment:2 by Eric Pettersen, 5 years ago

Resolution: → fixed
Status: accepted → closed

For now, just assume that items that look like numbers are numbers and sort accordingly. Add explicit control over case and numeric sorting later if actually needed.

Note: See TracTickets for help on using tickets.