Opened 6 years ago

Closed 6 years ago

#2751 closed defect (fixed)

Clip cap mistakenly remains visible

Reported by: goddard@… Owned by: Tom Goddard
Priority: normal Milestone:
Component: Surface Version:
Keywords: Cc:
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description 

The following bug report has been submitted:
Platform:        Darwin-19.2.0-x86_64-i386-64bit
ChimeraX Version: 0.92 (2020-01-14)
Description
With volume shown as mesh, clip near 0 followed by view command leaves clip cap visible.

Log:
Startup Messages  
---  
warning | 'clip' is a prefix of an existing command 'clipper'  
  
UCSF ChimeraX version: 0.92 (2020-01-14)  
© 2016-2019 Regents of the University of California. All rights reserved.  
How to cite UCSF ChimeraX  

> open 9333 fromDatabase emdb

Opened emd_9333.map, grid size 320,320,320, pixel 1.06, shown at level 0.321,
step 2, values float32  

> volume #1 style mesh

> clip near 0

> view




OpenGL version: 4.1 ATI-3.4.19
OpenGL renderer: AMD Radeon Pro Vega 20 OpenGL Engine
OpenGL vendor: ATI Technologies Inc.

Change History (2)

comment:1 by Eric Pettersen, 6 years ago

Component: Unassigned → Surface
Owner: set to Tom Goddard
Platform: → all
Project: → ChimeraX
Status: new → assigned
Summary: ChimeraX bug report submission → Clip cap mistakenly remains visible

comment:2 by Tom Goddard, 6 years ago

Resolution: → fixed
Status: assigned → closed

Fixed.

Clip plane change did not cause cap update because clip plane change flag was cleared before the capping code saw it. It was cleared when center of rotation was updated calling View.drawing_bounds() which called View.check_for_drawing_changes() which clears it. The View.drawing_bounds() calling check_for_drawing_changes() has been a big source of subtle problems. I made cofr update not call check for changes. Also the cap updating code is fragile since it can miss detecting clip planes changed. I added a comment to improve that some day.

Note: See TracTickets for help on using tickets.