Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#257 closed defect (fixed)

sym 2f43 gives traceback

Reported by: Elaine Meng Owned by: Tom Goddard
Priority: major Milestone:
Component: Higher-Order Structure Version:
Keywords: Cc:
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

open 2f43
sym #1
... reports assembly 1:

Assemblies for 2f43:
1 = author_defined_assembly (2,1 copies)

sym #1 ass 1
... gives traceback:

Traceback (most recent call last):
File "/Users/chimera/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/chimerax/cmd_line/gui.py", line 120, in on_enter
cmd.run(cmd_text)
File "/Users/chimera/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/chimerax/core/commands/cli.py", line 2120, in run
results.append(ci.function(session, kw_args))
File "/Users/chimera/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/chimerax/core/commands/sym.py", line 50, in sym
a.show(m, session)
File "/Users/chimera/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/chimerax/core/commands/sym.py", line 144, in show
mols = self._molecule_copies(mol, session)
File "/Users/chimera/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/chimerax/core/commands/sym.py", line 194, in _molecule_copies
mnew = [mol.copy('%s %d' % (mol.name,i)) for i in range(nm,n)]
File "/Users/chimera/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/chimerax/core/commands/sym.py", line 194, in <listcomp>
mnew = [mol.copy('%s %d' % (mol.name,i)) for i in range(nm,n)]
File "/Users/chimera/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/chimerax/core/atomic/structure.py", line 113, in copy
level_of_detail = self._level_of_detail)
File "/Users/chimera/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/chimerax/core/atomic/structure.py", line 94, in init
self.session.triggers.add_handler("begin save session", self._begin_ses_save),
AttributeError: 'int' object has no attribute 'triggers'

Change History (3)

comment:1 by Tom Goddard, 10 years ago

Resolution: fixed
Status: newclosed

Fixed.

2f43 had some matrices applied to one set of chains, and another set of matrices applied to another set of chains, requiring making a copy of the molecule, so one set of matrices could be used for each of 2 molecule copies. The copy code was broken due to changes a month ago to the AtomicStructure constructor arguments.

comment:2 by Elaine Meng, 10 years ago

Fix confirmed, thanks!  One related problem (but unlikely for users to find, so perhaps low priority) is a traceback after the following:

open 2f43
sym #1 a 1
close #2
sym #1 a 1

Traceback (most recent call last):
File "/Users/chimera/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/chimerax/cmd_line/gui.py", line 120, in on_enter
cmd.run(cmd_text)
File "/Users/chimera/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/chimerax/core/commands/cli.py", line 2122, in run
results.append(ci.function(session, **kw_args))
File "/Users/chimera/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/chimerax/core/commands/sym.py", line 54, in sym
a.show(m, session)
File "/Users/chimera/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/chimerax/core/commands/sym.py", line 151, in show
included_atoms, excluded_atoms = self._partition_atoms(m.atoms, chain_ids)
File "/Users/chimera/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/chimerax/core/atomic/molc.py", line 83, in get_prop
vcount = getattr(self, value_count)
File "/Users/chimera/Applications/ChimeraX_Daily.app/Contents/Library/Frameworks/Python.framework/Versions/3.5/lib/python3.5/site-packages/chimerax/core/atomic/molc.py", line 25, in get_prop
cget(self._c_pointer_ref, 1, v_ref)
AttributeError: 'AtomicStructure' object has no attribute '_c_pointer_ref'

comment:3 by Tom Goddard, 10 years ago

Fixed again.

Note: See TracTickets for help on using tickets.