Opened 6 years ago

Closed 6 years ago

#2479 closed defect (fixed)

Toolbar won't display

Reported by: goddard@… Owned by: Greg Couch
Priority: major Milestone:
Component: General Controls Version:
Keywords: Cc:
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

The following bug report has been submitted:
Platform:        Windows-10-10.0.18362
ChimeraX Version: 0.91 (2019-10-04)
Description
Toolbar does not display on startup in today's daily build.  It does in Oct 1 build on this same machine.  Also using the Tools menu to show the toolbar does not display it, although the Toolbar entry at the bottom of the Tools menu has a checkmark by it.

Log:
UCSF ChimeraX version: 0.91 (2019-10-04)  
© 2016-2019 Regents of the University of California. All rights reserved.  
How to cite UCSF ChimeraX  




OpenGL version: 3.3.0 NVIDIA 398.35
OpenGL renderer: GeForce GTX 1070 with Max-Q Design/PCIe/SSE2
OpenGL vendor: NVIDIA Corporation

Change History (8)

comment:1 by Tom Goddard, 6 years ago

Component: UnassignedGeneral Controls
Owner: set to Greg Couch
Platform: all
Priority: normalmajor
Project: ChimeraX
Status: newassigned
Summary: ChimeraX bug report submissionToolbar won't display

comment:2 by Greg Couch, 6 years ago

If you start ChimeraX from a cygwin terminal window, is there an error message? It's working for me at home, but I'm going to rebuild everything from scratch so I've got exactly the same version as the daily build.

comment:3 by Tom Goddard, 6 years ago

$ /cygdrive/c/Program\ Files/ChimeraX-Oct-4-2019/bin/ChimeraX.exe
Traceback (most recent call last):

File "C:\Program Files\ChimeraX-Oct-4-2019\bin\lib\site-packages\chimerax\core\toolshed\info.py", line 627, in start_tool

ti = api._api_caller.start_tool(api, session, self, tool_info)

File "C:\Program Files\ChimeraX-Oct-4-2019\bin\lib\site-packages\chimerax\core\toolshed\init.py", line 1633, in start_tool

return cls._get_func(api, "start_tool")(session, bi, ti)

File "C:\Program Files\ChimeraX-Oct-4-2019\bin\lib\site-packages\chimerax\toolbar\init.py", line 17, in start_tool

return tool.ToolbarTool(session, ti.name)

File "C:\Program Files\ChimeraX-Oct-4-2019\bin\lib\site-packages\chimerax\toolbar\tool.py", line 39, in init

self._build_ui()

File "C:\Program Files\ChimeraX-Oct-4-2019\bin\lib\site-packages\chimerax\toolbar\tool.py", line 54, in _build_ui

self._build_buttons()

File "C:\Program Files\ChimeraX-Oct-4-2019\bin\lib\site-packages\chimerax\toolbar\tool.py", line 158, in _build_buttons

if display_name.startswith("") or display_name not in section_info:

AttributeError: 'NoneType' object has no attribute 'startswith'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):

File "C:\Program Files\ChimeraX-Oct-4-2019\bin\lib\site-packages\chimerax\core\tools.py", line 414, in start_tools

bi.start_tool(session, tool_name)

File "C:\Program Files\ChimeraX-Oct-4-2019\bin\lib\site-packages\chimerax\core\toolshed\info.py", line 633, in start_tool

"start_tool() failed for tool %s in bundle %s:\n%s" % (tool_name, self.name, str(e)))

chimerax.core.toolshed.ToolshedError: start_tool() failed for tool Toolbar in bundle ChimeraX-Toolbar:
'NoneType' object has no attribute 'startswith'
Tool "Toolbar" failed to start

comment:4 by Tom Goddard, 6 years ago

I thought all errors before startup were supposed to appear in the log if ChimeraX starts. This is really important for debugging. I'll make a separate ticket for that.

comment:5 by Tom Goddard, 6 years ago

This needs to be fixed. Max Krummel's lab is trying to do a demo on Monday with VR and they don't have a usable ChimeraX. Please at least back out the code you broke in yesterday's commit.

comment:6 by Greg Couch, 6 years ago

Fixed. Linked button's display_name was None and should have been a string.

in reply to:  7 ; comment:7 by goddard@…, 6 years ago

Thanks!

comment:8 by Greg Couch, 6 years ago

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.