Opened 6 years ago

Closed 5 years ago

#2359 closed defect (fixed)

Optimize ribbon drawing

Reported by: Tristan Croll Owned by: Tom Goddard
Priority: moderate Milestone:
Component: Depiction Version:
Keywords: Cc:
Blocked By: Blocking:
Notify when closed: Platform: all
Project: ChimeraX

Description

As per ticket #2355, _update_ribbon_graphics takes 27ms/frame to redraw 4v90 even with no ribbons displayed at all, which impacts the overall frame rate.

Change History (3)

in reply to:  1 ; comment:1 by goddard@…, 6 years ago 

The Structure._update_ribbon_graphics() routine actually does not recompute ribbons, it only updates the selection highlight for a ribbon.  When running ISOLDE often there is a selection -- I don't know if Tristan's timing had some residues selected.  At any rate it should be easy to optimize for the case where there are no ribbons.  Would probably also be good to rename _update_ribbon_graphics to _update_ribbon_selection_graphics.  Recomputing ribbons is done in a different routine _create_ribbon_graphics.

comment:2 by Elaine Meng, 5 years ago

Cc: Tom Goddard removed
Owner: changed from Conrad Huang to Tom Goddard

comment:3 by Tom Goddard, 5 years ago

Resolution: → fixed
Status: assigned → closed

Ribbon code was optimized about a year ago before the 1.0 release. Please submit a new ticket if ribbon performance is still poor in some cases.

Note: See TracTickets for help on using tickets.