Showing all tools suppressed during global tool hide

[goddard@…]

The following bug report has been submitted:
Platform:        Darwin-18.7.0-x86_64-i386-64bit
ChimeraX Version: 0.91 (2019-08-05)
Description
If tools are hidden by the icon in the lower right corner of the main window then the help menu entries do not show the help browser.  This is very confusing.  It took me a minute before I saw that the status line said something like "tool display supressed" when I use Help / User Guide.

I think it should show a tool if I asked it to show a tool, especially if it is a floating window like Help browser or Report a Bug (which also would not show when I used Help / Report a Bug).

Log:
UCSF ChimeraX version: 0.91 (2019-08-05)  
© 2016-2019 Regents of the University of California. All rights reserved.  
How to cite UCSF ChimeraX  

> help clashes

> help clashes




OpenGL version: 4.1 ATI-2.11.20
OpenGL renderer: AMD Radeon Pro 580 OpenGL Engine
OpenGL vendor: ATI Technologies Inc.

[goddard@…]

This is especially strange behavior since the hide tools button does not hide the Help Browser floating window when it is showing and the button is pressed.

[pett]

I believe the thinking was that the user has requested that all docked tools be hidden, and by golly it's going to stay that way (since it doesn't know if a launched tool is going to start docked or not). I think I can do better. For reference, my plan is:

Stop suppressing tool launch. Check in the ToolWindow.manage() call if the find if the tool window is going to float or not. If not, check the global hide state and unhide everything first. Maybe also connect to the docking-area-changed trigger in case the user drops in a floating window and also unhide?

[goddard@…]

Yeah, I think if a new tool is shown but tools are being hidden, well the user wanted to show a tool, so unhiding all the tools is the right thing to do.  If the new tool is floating, it might be better though to not unhide all tools, and just show the new floating one (e.g. the Help Browser).

[pett]

Also check that concerns in ticket #2404 are fully addressed. Closing that ticket as largely a duplicate.

[pett]

Okay, AFAICT all the concerns in this ticket and #2404 are addressed.